Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update Issue Templates #2305

Closed
mahieyin-rahmun opened this issue Jul 4, 2021 · 6 comments · Fixed by #2306 or #2308
Closed

chore(docs): Update Issue Templates #2305

mahieyin-rahmun opened this issue Jul 4, 2021 · 6 comments · Fixed by #2306 or #2308

Comments

@mahieyin-rahmun
Copy link
Contributor

mahieyin-rahmun commented Jul 4, 2021

Originally posted by @balazsorban44 in #2274 (comment)

@mahieyin-rahmun just a minor thing, but could you please remove the prefixes in titles in a subsequent PR?
I don't think we need them (eg.: [Bug]:), as we have the labels anyway. They take up significant space, especially in the github mobile app, and it's harder to guess the content from the title. 😊
Also, SOME kind of reproduction should be REQUIRED. I just converted 2 questions, none of them had any code reproduction...

@mahieyin-rahmun
Copy link
Contributor Author

mahieyin-rahmun commented Jul 4, 2021

@balazsorban44, I think we introduced a bug with the last PR:

image

I can confirm this, since Issue Templates are no longer being used:

image

The fault lies with me, I should have checked it in a sandbox repo :(

@balazsorban44
Copy link
Member

balazsorban44 commented Jul 4, 2021

😬

Something like this would make sense you think?

https://stackoverflow.com/questions/34089496/empty-field-in-yaml

(appearantly two single quotes could work as well)

I reopen this until fixed.

@mahieyin-rahmun
Copy link
Contributor Author

😬

Something like this would make sense you think?

https://stackoverflow.com/questions/34089496/empty-field-in-yaml

I will check this and get back to you in a bit.

@balazsorban44 balazsorban44 reopened this Jul 4, 2021
@balazsorban44
Copy link
Member

https://github.com/vercel/next.js/blob/canary/.github/ISSUE_TEMPLATE/1.bug_report.yml

so the easiest way to solve this is to just leave out the title field! 😅

@mahieyin-rahmun
Copy link
Contributor Author

mahieyin-rahmun commented Jul 4, 2021

Something like this would make sense you think?

https://stackoverflow.com/questions/34089496/empty-field-in-yaml

(appearantly two single quotes could work as well)

I reopen this until fixed.

Neither '' nor ~ works. The title must be a string and it must be surrounded in double quotations

https://github.com/vercel/next.js/blob/canary/.github/ISSUE_TEMPLATE/1.bug_report.yml

so the easiest way to solve this is to just leave out the title field!

What an unintuitive approach 🤦 Alright, I will update and make another PR

@balazsorban44
Copy link
Member

thanks! looking good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants