Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment plugins not compatible with #241 #258

Closed
njzjz opened this issue Apr 28, 2021 · 3 comments · Fixed by #259
Closed

Comment plugins not compatible with #241 #258

njzjz opened this issue Apr 28, 2021 · 3 comments · Fixed by #259

Comments

@njzjz
Copy link
Member

njzjz commented Apr 28, 2021

Plugins like hexo-next-valine is not compatible with #241.

At least, we need to change to following script
(https://github.com/next-theme/hexo-next-valine/blob/037e404c471d6ecd70130f9fccc04b5492504abe/valine.njk#L4)

  NexT.utils.getScript('https://cdn.jsdelivr.net/npm/[email protected]/dist/Valine.min.js', () => {

to

  NexT.utils.getScript('https://cdn.jsdelivr.net/npm/[email protected]/dist/Valine.min.js').then(() => { 

However, I don't know whether we need to continue to support the old version of NexT.

@njzjz
Copy link
Member Author

njzjz commented Apr 28, 2021

Others comment plugins listed in https://github.com/next-theme/awesome-next#comment will face the same problem.

Another solution is to add compatibility to the getScript function.

@PaperStrike
Copy link
Member

Okay. I thought there was no other script using this function. Will make getScript and loadComments backward compatible later.

@PaperStrike PaperStrike transferred this issue from next-theme/hexo-next-valine Apr 29, 2021
@PaperStrike PaperStrike changed the title the plugin is not compatible with the latest NexT code Comment plugins not compatible with #241 Apr 29, 2021
@stevenjoezhang stevenjoezhang added this to the 8.4.0 milestone Apr 30, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants