feat(synthetics): add secure credentials resource #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ctrombley
force-pushed
the
feat/synthetics-secure-credentials
branch
from
641213a to
9300e3b
Compare
ctrombley
force-pushed
the
feat/synthetics-secure-credentials
branch
from
a41ccfd to
2ec90e8
Compare
zlesnr
reviewed
Feb 19, 2020
| "github.com/hashicorp/terraform-plugin-sdk/helper/schema" | ||
| ) | ||
|
|
||
| func dataSourceNewRelicSyntheticsSecureCredential() *schema.Resource { |
There was a problem hiding this comment.
For my own education, is there anything here that marks this a data source other than the file name? This looks pretty similar to the resources below.
There was a problem hiding this comment.
A data source only has a Read function, and the Schema excludes fields that are not returned (in this case value is not returned by the API, so it's not included in the schema). I agree that there is a bit of duplication here, but not sure how to remove it without adding complexity to reading the code.
There was a problem hiding this comment.
@zlesnr It's wired up in newrelic/provider.go in the collection of data sources, rather than in the collection of resources.
kidk
pushed a commit
to aminoz007/terraform-provider-newrelic
that referenced
this pull request
Oct 12, 2021
* feat(synthetics): add secure credentials resource * feat(synthetics) add secure credential data source * docs(synthetics): document synthetics secure credentials resource and data source * chore(synthetics): linting and refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404 .
This PR introduces a resource and data source for Synthetics secure credentials, following existing patterns.