feat: replace provider backend with newrelic-client-go #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
This was referenced Jan 24, 2020
sanderblue
reviewed
Jan 24, 2020
sanderblue
reviewed
Jan 25, 2020
| @@ -173,12 +174,16 @@ func testAccCheckNewRelicAlertPolicyExists(n string) resource.TestCheckFunc { | |||
|
|
|||
| func testAccDeleteAlertPolicy(name string) func() { | |||
There was a problem hiding this comment.
Not a blocker, but it looks like we have a duplicate of this function in helpers_test.go.
ctrombley
force-pushed
the
feat/remove-go-newrelic
branch
from
8fa315d to
f463af5
Compare
ctrombley
force-pushed
the
feat/remove-go-newrelic
branch
from
f463af5 to
da0cacb
Compare
kidk
pushed a commit
to aminoz007/terraform-provider-newrelic
that referenced
this pull request
Oct 12, 2021
* feat: replace provider backend with newrelic-client-go * chore: update to newrelic-client-go v0.7.0 * fix: make the newrelic_alert_condition resource's condition_scope field required * fix: allow logging and TLS configuration for the new client * refactor: incorporate code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #354 .
This PR removes the reference to the go-newrelic module, and puts a single instance of the
NewRelicclient in place for the backend of the provider.