Skip to content

Commit c54d289

Browse files
authored
Upgrade integrations SDK (NR-302384) (#258)
* use storer from sdk * upgrade infra-sdk to a compatible v3 version * add entry to changelog * go mod tidy * go upgrade to 1.23.2 * add entry to changelog for go 1.22.3
1 parent facbeb7 commit c54d289

24 files changed

+43
-44
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ Unreleased section should follow [Release Toolkit](https://github.com/newrelic/r
99

1010
## Unreleased
1111

12+
### dependency
13+
14+
- Upgrade go to 1.23.2
15+
16+
### enhancements
17+
18+
- Upgrade integrations SDK so the interval is variable and allows intervals up to 5 minutes
19+
1220
## v2.0.9 - 2024-09-10
1321

1422
### ⛓️ Dependencies

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG infra_image=newrelic/infrastructure-bundle
22

3-
FROM golang:1.23.1 as builder
3+
FROM golang:1.23.2 as builder
44

55
WORKDIR /go/src/github.com/newrelic/nri-docker
66
COPY . .

build/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.23.1-bookworm
1+
FROM golang:1.23.2-bookworm
22

33
ARG GH_VERSION='2.23.0'
44

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
module github.com/newrelic/nri-docker
22

3-
go 1.23.1
3+
go 1.23.2
44

55
require (
66
github.com/containerd/cgroups v1.1.0
77
github.com/docker/docker v26.1.5+incompatible
88
github.com/dustin/go-humanize v1.0.1
9-
github.com/newrelic/infra-integrations-sdk v3.8.2+incompatible
9+
github.com/newrelic/infra-integrations-sdk/v3 v3.9.1
1010
github.com/stretchr/testify v1.9.0
1111
)
1212

go.sum

+2-4
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
1717
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1818
github.com/distribution/reference v0.5.0 h1:/FUIFXtfc/x2gpa5/VGfiGLuOIdYa1t65IKK2OFGvA0=
1919
github.com/distribution/reference v0.5.0/go.mod h1:BbU0aIcezP1/5jX/8MP0YiH4SdvB5Y4f/wlDRiLyi3E=
20-
github.com/docker/docker v26.1.4+incompatible h1:vuTpXDuoga+Z38m1OZHzl7NKisKWaWlhjQk7IDPSLsU=
21-
github.com/docker/docker v26.1.4+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
2220
github.com/docker/docker v26.1.5+incompatible h1:NEAxTwEjxV6VbBMBoGG3zPqbiJosIApZjxlbrG9q3/g=
2321
github.com/docker/docker v26.1.5+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
2422
github.com/docker/go-connections v0.4.0 h1:El9xVISelRB7BuFusrZozjnkIM5YnzCViNKohAFqRJQ=
@@ -63,8 +61,8 @@ github.com/moby/term v0.0.0-20221128092401-c43b287e0e0f h1:J/7hjLaHLD7epG0m6TBMG
6361
github.com/moby/term v0.0.0-20221128092401-c43b287e0e0f/go.mod h1:15ce4BGCFxt7I5NQKT+HV0yEDxmf6fSysfEDiVo3zFM=
6462
github.com/morikuni/aec v1.0.0 h1:nP9CBfwrvYnBRgY6qfDQkygYDmYwOilePFkwzv4dU8A=
6563
github.com/morikuni/aec v1.0.0/go.mod h1:BbKIizmSmc5MMPqRYbxO4ZU0S0+P200+tUnFx7PXmsc=
66-
github.com/newrelic/infra-integrations-sdk v3.8.2+incompatible h1:Ktcm1aPAl7CW3o+FXAIKJ+jygWVXDXaUIWFyf2CXQTk=
67-
github.com/newrelic/infra-integrations-sdk v3.8.2+incompatible/go.mod h1:tMUHRMq6mJS0YyBnbWrTXAnREnQqC1AGO6Lu45u5xAM=
64+
github.com/newrelic/infra-integrations-sdk/v3 v3.9.1 h1:dCtVLsYNHWTQ5aAlAaHroomOUlqxlGTrdi6XTlvBDfI=
65+
github.com/newrelic/infra-integrations-sdk/v3 v3.9.1/go.mod h1:yPeidhcq9Cla0QDquGXH0KqvS2k9xtetFOD7aLA0Z8M=
6866
github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8Oi/yOhh5U=
6967
github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM=
7068
github.com/opencontainers/image-spec v1.0.2 h1:9yCKha/T5XdGtO0q9Q9a6T5NUCsTn/DrBg0D7ufOcFM=

src/biz/metrics.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import (
1111
"time"
1212

1313
"github.com/docker/docker/api/types"
14-
"github.com/newrelic/infra-integrations-sdk/log"
15-
"github.com/newrelic/infra-integrations-sdk/persist"
14+
"github.com/newrelic/infra-integrations-sdk/v3/log"
15+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1616

1717
"github.com/newrelic/nri-docker/src/raw"
1818
)

src/biz/metrics_aws_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"net/url"
99
"testing"
1010

11-
"github.com/newrelic/infra-integrations-sdk/persist"
11+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1212
"github.com/stretchr/testify/assert"
1313
"github.com/stretchr/testify/require"
1414

src/biz/metrics_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
"github.com/docker/docker/api/types"
1010
"github.com/docker/docker/api/types/container"
11-
"github.com/newrelic/infra-integrations-sdk/persist"
11+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1212
"github.com/newrelic/nri-docker/src/raw"
1313
"github.com/stretchr/testify/assert"
1414
)

src/config/config.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package config
22

3-
import "github.com/newrelic/infra-integrations-sdk/args"
3+
import "github.com/newrelic/infra-integrations-sdk/v3/args"
44

55
type ArgumentList struct {
66
args.DefaultArgumentList
@@ -14,6 +14,4 @@ type ArgumentList struct {
1414
// CgroupPath and CgroupDriver arguments are not used but are kept here for backwards compatibility reasons.
1515
CgroupPath string `default:"" help:"Deprecated. cgroup_path argument is not used anymore."`
1616
CgroupDriver string `default:"" help:"Deprecated. cgroup_driver argument is not used anymore."`
17-
18-
CacheTTL string `default:"1m" help:"Set the maximum cache TTL that the integration is going to use to calculate rates and deltas. Possible values are time-strings: 1s, 1m, 1h"`
1917
}

src/docker.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88

99
"github.com/docker/docker/api/types/system"
1010
"github.com/docker/docker/client"
11-
"github.com/newrelic/infra-integrations-sdk/integration"
12-
"github.com/newrelic/infra-integrations-sdk/log"
11+
"github.com/newrelic/infra-integrations-sdk/v3/integration"
12+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1313
"github.com/newrelic/nri-docker/src/config"
1414
"github.com/newrelic/nri-docker/src/nri"
1515
"github.com/newrelic/nri-docker/src/raw"

src/nri/metrics.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// by the New Relic Infrastructure Agent
33
package nri
44

5-
import "github.com/newrelic/infra-integrations-sdk/data/metric"
5+
import "github.com/newrelic/infra-integrations-sdk/v3/data/metric"
66

77
var (
88
metricCommandLine = metricFunc("commandLine", metric.ATTRIBUTE)

src/nri/sampler.go

+6-11
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import (
99
"github.com/docker/docker/api/types"
1010
"github.com/docker/docker/api/types/container"
1111
"github.com/docker/docker/api/types/system"
12-
"github.com/newrelic/infra-integrations-sdk/data/attribute"
13-
"github.com/newrelic/infra-integrations-sdk/data/metric"
14-
"github.com/newrelic/infra-integrations-sdk/integration"
15-
"github.com/newrelic/infra-integrations-sdk/log"
16-
"github.com/newrelic/infra-integrations-sdk/persist"
12+
"github.com/newrelic/infra-integrations-sdk/v3/data/attribute"
13+
"github.com/newrelic/infra-integrations-sdk/v3/data/metric"
14+
"github.com/newrelic/infra-integrations-sdk/v3/integration"
15+
"github.com/newrelic/infra-integrations-sdk/v3/log"
16+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1717

1818
"github.com/newrelic/nri-docker/src/biz"
1919
"github.com/newrelic/nri-docker/src/config"
@@ -39,11 +39,6 @@ type ContainerSampler struct {
3939

4040
// NewSampler returns a ContainerSampler instance.
4141
func NewSampler(fetcher raw.Fetcher, docker raw.DockerClient, config config.ArgumentList) (*ContainerSampler, error) {
42-
cacheTTL, err := time.ParseDuration(config.CacheTTL)
43-
if err != nil {
44-
return nil, err
45-
}
46-
4742
exitedContainerTTL, err := time.ParseDuration(config.ExitedContainersTTL)
4843
if err != nil {
4944
return nil, err
@@ -53,7 +48,7 @@ func NewSampler(fetcher raw.Fetcher, docker raw.DockerClient, config config.Argu
5348
store, err := persist.NewFileStore(
5449
persist.TmpPath(config.TempDir, "container_cpus"),
5550
log.NewStdErr(true),
56-
cacheTTL)
51+
config.CacheTTL)
5752
if err != nil {
5853
return nil, err
5954
}

src/nri/sampler_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"testing"
66
"time"
77

8-
"github.com/newrelic/infra-integrations-sdk/integration"
8+
"github.com/newrelic/infra-integrations-sdk/v3/integration"
99
"github.com/stretchr/testify/assert"
1010
"github.com/stretchr/testify/require"
1111

src/raw/aws/fargate_fetcher.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88
"time"
99

1010
docker "github.com/docker/docker/api/types"
11-
"github.com/newrelic/infra-integrations-sdk/log"
12-
"github.com/newrelic/infra-integrations-sdk/persist"
11+
"github.com/newrelic/infra-integrations-sdk/v3/log"
12+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1313

1414
"github.com/newrelic/nri-docker/src/raw"
1515
)

src/raw/aws/fargate_inspector.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import (
1111

1212
"github.com/docker/docker/api/types"
1313
"github.com/docker/docker/api/types/container"
14-
"github.com/newrelic/infra-integrations-sdk/log"
15-
"github.com/newrelic/infra-integrations-sdk/persist"
14+
"github.com/newrelic/infra-integrations-sdk/v3/log"
15+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1616
)
1717

1818
const fargateTaskMetadataCacheKey = "task-metadata-response"

src/raw/aws/fargate_metadata.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"os"
2323
"time"
2424

25-
"github.com/newrelic/infra-integrations-sdk/log"
25+
"github.com/newrelic/infra-integrations-sdk/v3/log"
2626
)
2727

2828
const (

src/raw/aws/fargate_raw_metrics.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package aws
33
import (
44
"time"
55

6-
"github.com/newrelic/infra-integrations-sdk/log"
6+
"github.com/newrelic/infra-integrations-sdk/v3/log"
77
"github.com/newrelic/nri-docker/src/raw"
88
)
99

src/raw/cgroup_detect.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"path/filepath"
77
"strings"
88

9-
"github.com/newrelic/infra-integrations-sdk/log"
9+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1010
)
1111

1212
const (

src/raw/cgroupv1.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
"github.com/containerd/cgroups"
1515
cgroupstats "github.com/containerd/cgroups/stats/v1"
1616
"github.com/docker/docker/api/types"
17-
"github.com/newrelic/infra-integrations-sdk/log"
17+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1818
)
1919

2020
const nanoSecondsPerSecond = 1e9

src/raw/cgroupv2.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
cgroupsV2 "github.com/containerd/cgroups/v2"
1111
cgroupstatsV2 "github.com/containerd/cgroups/v2/stats"
1212
"github.com/docker/docker/api/types"
13-
"github.com/newrelic/infra-integrations-sdk/log"
13+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1414
)
1515

1616
// CgroupsV2Fetcher fetches the metrics that can be found in cgroups (v2) file system

src/raw/dockerapi/fetcher.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
"github.com/docker/docker/api/types"
1010
"github.com/docker/docker/api/types/container"
11-
"github.com/newrelic/infra-integrations-sdk/log"
11+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1212
"github.com/newrelic/nri-docker/src/raw"
1313
)
1414

src/raw/network_stats_getter.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
"strconv"
88
"strings"
99

10-
"github.com/newrelic/infra-integrations-sdk/log"
10+
"github.com/newrelic/infra-integrations-sdk/v3/log"
1111
)
1212

1313
type NetworkStatsGetter interface {

test/integration/common.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"time"
1212

1313
"github.com/docker/docker/client"
14-
"github.com/newrelic/infra-integrations-sdk/args"
14+
"github.com/newrelic/infra-integrations-sdk/v3/args"
1515
"github.com/newrelic/nri-docker/src/config"
1616
"github.com/stretchr/testify/assert"
1717
"github.com/stretchr/testify/require"

test/integration/metrics_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import (
1414

1515
"github.com/docker/docker/api/types"
1616
"github.com/docker/docker/client"
17-
"github.com/newrelic/infra-integrations-sdk/log"
18-
"github.com/newrelic/infra-integrations-sdk/persist"
17+
"github.com/newrelic/infra-integrations-sdk/v3/log"
18+
"github.com/newrelic/infra-integrations-sdk/v3/persist"
1919
"github.com/stretchr/testify/assert"
2020
"github.com/stretchr/testify/mock"
2121
"github.com/stretchr/testify/require"

0 commit comments

Comments
 (0)