fix: Updated openai instrumentation to properly return APIPromise to avoid crashing when using completions.parse or responses.parse
#3382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid crashing when using `completions.parse` or `responses.parse`
bizob2828
force-pushed
the
fix-openai-instrumentation
branch
from
aa57ce8 to
90fcf63
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 97.66% 97.59% -0.07%
==========================================
Files 366 366
Lines 52555 52585 +30
Branches 1 1
==========================================
- Hits 51326 51322 -4
- Misses 1229 1263 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsumners-nr
approved these changes
Sep 22, 2025
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The linked bug found an issue with how we're now instrumenting
openaiwith the tracing channel. I determined this is actually a bug in Node.js. In the meantime, we can work around it by wrapping the functions we need intraceSyncand propagating and emitting the results in the resolve/reject blocks of the promise.Note: I added a test to prove this no longer crashes, but I can't seem to get it to succeed with our mock server. I want to test with a live openai instance to ensure there aren't more issues, but I don't expect there to be.
How to Test
Related Issues
Fixes #3379