Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine resolution to superagent@10 breaking versioned tests #2451

Closed
jsumners-nr opened this issue Aug 12, 2024 · 3 comments · Fixed by #2456
Closed

Determine resolution to superagent@10 breaking versioned tests #2451

jsumners-nr opened this issue Aug 12, 2024 · 3 comments · Fixed by #2456
Labels
needs-triage

Comments

@jsumners-nr
Copy link
Contributor

Version 10 of superagent is causing our versioned tests to fail. We need to determine the cause and a fix. See #2439
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-302004

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Aug 12, 2024
@bizob2828
Copy link
Member

I think this is a case of waiting on superagent. they have 2 prs to fix the issue: ladjs/superagent#1813, and ladjs/superagent#1814

@titanism
Copy link

superagent v10.0.1 is released (we removed re2 dependency)

https://github.com/ladjs/superagent/releases/tag/v10.0.1

@jsumners-nr jsumners-nr mentioned this issue Aug 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed in Node.js Engineering Board Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Removed limit on superagent versioned testing jsumners-nr/node-newrelic
3 participants
@bizob2828 @titanism @jsumners-nr