Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-sdk/[email protected] fails to add aws.* attributes to the external span #2378

Closed
bizob2828 opened this issue Jul 19, 2024 · 2 comments · Fixed by #2382
Closed

@aws-sdk/[email protected] fails to add aws.* attributes to the external span #2378

bizob2828 opened this issue Jul 19, 2024 · 2 comments · Fixed by #2382
Assignees
@bizob2828
Labels
bug points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

bizob2828 commented Jul 19, 2024 •
edited
Loading

Description

It looks like in @aws-sdk/[email protected] our versioned tests stop working. The reason is because the context manager returns the root span in addAwsAttribute middleware. It looks like the root cause is https://github.com/aws/aws-sdk-js-v3/pull/6232/files. The response is getting wrapped in a stream and we rely on the IncomingMessage to get the external span.

Expected Behavior

s3 client adds the aws.* to the appropriate span.

Steps to Reproduce

npm run versioned:internal:major aws-sdk-v3
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-293504

@bizob2828 bizob2828 added points: 5 1-2 weeks and removed needs-triage labels Jul 19, 2024
@bizob2828 bizob2828 self-assigned this Jul 19, 2024
@bizob2828 bizob2828 changed the title @aws-sdk/client-s3 does not add aws.* attributes to the appropriate span aws mock doesn't work with @aws-sdk/[email protected]+ Jul 19, 2024
@bizob2828
Copy link
Member Author

This is a bug but I have confirmed it is not a bug in instrumentation, just how we're mocking the aws server in versioned tests

@bizob2828 bizob2828 changed the title aws mock doesn't work with @aws-sdk/[email protected]+ @aws-sdk/[email protected] fails to add aws.* attributes to the external span Jul 19, 2024
@bizob2828 bizob2828 mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
bug points: 5 1-2 weeks
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
1 participant
@bizob2828