Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel compliant attributes for database spans #2149

Closed
bizob2828 opened this issue Apr 17, 2024 · 1 comment · Fixed by #2173
Closed

Add otel compliant attributes for database spans #2149

bizob2828 opened this issue Apr 17, 2024 · 1 comment · Fixed by #2173
Assignees
Labels
points: 3 A few days

Comments

@bizob2828
Copy link
Member

bizob2828 commented Apr 17, 2024

Description

We are trying to align on gaps with our span attributes and OpenTelemetry specification. With that being said we are missing db.system, server.address and server.port

Acceptance Criteria

All database spans(non-streaming and streaming) should provide db.system, server.address, and server.port

Additional context

Note: These are not the segment attributes. Spans get created from segments when a transaction ends here

  • Ruby PR
  • The db spans attributes are created in the DatastoreSpanEvent and StreamingDatastoreSpanEvent
  • db.system is the same as intrinsics.component
  • server.address is same as peer.hostname
  • server.port is the port portion of peer.address but is constructed from agentAttributes.port_path_or_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 3 A few days
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants