Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test Padrino with Sinatra v3+ after it is known to be compatible #1466

Closed
fallwith opened this issue Sep 26, 2022 · 7 comments
Closed

CI: test Padrino with Sinatra v3+ after it is known to be compatible #1466

fallwith opened this issue Sep 26, 2022 · 7 comments
Milestone
New Instrumentation

Comments

@fallwith
Copy link
Contributor

With #1465 we had to lock Sinatra to < 3 for our Padrino tests, as Padrino seems to want to modify the CALLERS_TO_IGNORE array which is now frozen with Sinatra 3.0.0.

After Padrino releases a new version of padrino-core beyond the current 0.15.1 version, we should check to see if we are able to revert the change that #1465 delivered. NOTE that a new version of padrino-core need not specifically solve the Sinatra v3.0.0 compatibility problem. It could also simply add a dependency on Sinatra < 3 so that we no longer have to do so manually.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-3879

@kaylareopelle kaylareopelle added this to the New Instrumentation milestone Oct 5, 2022
@fallwith
Copy link
Contributor Author

NOTE: Padrino development is considered to be halted.

@fallwith
Copy link
Contributor Author

Filed padrino-framework#2258

@fallwith
Copy link
Contributor Author

Closing until Padrino lives again

@fallwith
Copy link
Contributor Author

The padrino-framework#2258 issue I filed has been completed. We should be set to test Padrino with Sinatra 3+ after a new version of Padrino (newer than 0.15.1) is released.

@fallwith fallwith reopened this Dec 19, 2022
@workato-integration
Copy link

Work has been completed on this issue.

@nesquena
Copy link

I've now deployed 0.15.2 with the fixes

@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
New Instrumentation
Development

No branches or pull requests
3 participants
@nesquena @fallwith @kaylareopelle