Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang opentelemetry sdk doesn't support delta aggregations with PrecomputedSum #156

Closed
veqryn opened this issue Jun 16, 2022 · 3 comments · Fixed by #157
Closed

Golang opentelemetry sdk doesn't support delta aggregations with PrecomputedSum #156

veqryn opened this issue Jun 16, 2022 · 3 comments · Fixed by #157
Labels
bug Something isn't working

Comments

@veqryn
Copy link

veqryn commented Jun 16, 2022

See notes here: open-telemetry/opentelemetry-go#2868

The current example has a temporality selector that forces CounterObserver to use delta temporality, which causes the opentelemetry sdk to throw errors and not export the metric.

@veqryn veqryn added the bug Something isn't working label Jun 16, 2022
@veqryn veqryn changed the title Golang opentelemetry sdk doesn't support delta aggregation histograms Golang opentelemetry sdk doesn't support delta aggregations with PrecomputedSum Jun 16, 2022
@TylerHelmuth
Copy link
Contributor

I agree. If I add an CounterObserver to the metrics.go example it will print out "cumulative to delta not implemented" and not export the metric.

This is a limitation with the Go Metrics SDK, which isn't stable yet. Being able to set delta temporality for Async Counters is part of the otel specification, though, so I would expect the capability to be added before a stable Go metrics SDK release.

For this example, if we switch CounterObserverInstrumentKind to delta then New Relic will treat the data as a Gauge, which is slightly misleading.

@TylerHelmuth
Copy link
Contributor

Guess that is better than an error though. I will update the temporality selector so that an error is not thrown. When the Go SDK supports delta temporality for these instruments in the future I will add it back.

@veqryn
Copy link
Author

veqryn commented Jun 16, 2022

I can make a PR if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants