Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable https proxies in Telemetry SDK #1398

Closed
cayetanocobaleda opened this issue Jul 17, 2023 · 2 comments
Closed

Enable https proxies in Telemetry SDK #1398

cayetanocobaleda opened this issue Jul 17, 2023 · 2 comments
Labels
3 Story Point Estimate feature request Suggestion for a new product enhancement or change

Comments

@cayetanocobaleda
Copy link

As things stand today, the Telemetry SDK uses the OkHttpClient, which does not fully support HTTPS proxies:

square/okhttp#3787

This impacts products built on top of the Telemetry SDK. For example, our implementation of the Java Flight Recorder, which is currently bundled with the Java agent, uses the Telemetry SDK under the hood. The result of this is that if a customer is using an HTTPS proxy, most Java agent telemetry data is sent up without issue, but JFR data fails with the following exception:

2023-05-29T15:03:47,556+1000 [1 73] com.newrelic INFO: [MetricBatch] - Batch sending failed. Backing off 15000 MILLISECONDS
2023-05-29T15:03:47,866+1000 [1 74] com.newrelic WARN: IOException (message: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target, cause: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target) while trying to send data to New Relic. EventBatch retry recommended

Because the issue lies with the OkHttpClient, we cannot easily implement a fix unless one of two things happens:

OkHttpClient implements support for HTTPS proxies.
We refactor the Telemetry SDK to use a different HttpClient.

@cayetanocobaleda cayetanocobaleda added the feature request Suggestion for a new product enhancement or change label Jul 17, 2023
@workato-integration
Copy link

@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Jul 19, 2023
@kford-newrelic kford-newrelic added 3 Story Point Estimate and removed estimate Issue needing estimation labels Jul 20, 2023
@workato-integration
Copy link

The problem is a duplicate of an existing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Story Point Estimate feature request Suggestion for a new product enhancement or change
Projects
None yet
Development

No branches or pull requests

2 participants