Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSErrors timestamped per harvest #997

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

patrickhousley
Copy link
Contributor

JSErrors that happen multiple times throughout a page's life will now receive a timestamp unique to the agent harvest cycle instead of always reporting the timestamp of the first occurrence of that error.

Overview

Modified the JSErrors feature to cache the error timestamp per harvest cycle instead of per page lifecycle.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-261440

Testing

Copy link

github-actions bot commented Apr 23, 2024

Static Badge

Last ran on April 23, 2024 10:55:58 CDT
Checking merge of (dccc6e3) into main (f35bc1d)

Copy link

github-actions bot commented Apr 23, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.83 kB / 11.13 kB (gzip) 31.83 kB / 11.13 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51 kB / 16.59 kB (gzip) 51 kB / 16.59 kB (gzip) 0% / 0% (gzip)
pro loader 51.75 kB / 17.55 kB (gzip) 51.75 kB / 17.55 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 93.53 kB / 28.58 kB (gzip) 93.55 kB / 28.58 kB (gzip) 0.02% / 0.01% (gzip)
spa loader 59.7 kB / 19.98 kB (gzip) 59.7 kB / 19.98 kB (gzip) 0% / 0.01% (gzip)
spa async-chunk 108.6 kB / 32.99 kB (gzip) 108.62 kB / 32.99 kB (gzip) 0.02% / 0% (gzip)
lite-polyfills loader 125.76 kB / 40.43 kB (gzip) 125.76 kB / 40.43 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 65.72 kB / 18.91 kB (gzip) 65.72 kB / 18.91 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 146.01 kB / 46.43 kB (gzip) 146.01 kB / 46.43 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 128.38 kB / 33.43 kB (gzip) 128.4 kB / 33.43 kB (gzip) 0.02% / 0% (gzip)
spa-polyfills loader 154.03 kB / 48.55 kB (gzip) 154.03 kB / 48.55 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 145.19 kB / 38.05 kB (gzip) 145.21 kB / 38.05 kB (gzip) 0.02% / 0% (gzip)

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.81%. Comparing base (f35bc1d) to head (dccc6e3).

Files Patch % Lines
src/features/jserrors/aggregate/index.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   83.90%   83.81%   -0.10%     
==========================================
  Files         154      154              
  Lines        7157     7165       +8     
  Branches     1420     1420              
==========================================
  Hits         6005     6005              
- Misses        985      988       +3     
- Partials      167      172       +5     
Flag Coverage Δ
integration-tests 90.48% <100.00%> (+0.02%) ⬆️
unit-tests 67.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to work as intended manual, plus verified retry logic

@patrickhousley patrickhousley merged commit 97ae128 into main Apr 23, 2024
49 of 51 checks passed
@patrickhousley patrickhousley deleted the error-harvest-timestamp branch April 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants