-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: JSErrors timestamped per harvest #997
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 83.90% 83.81% -0.10%
==========================================
Files 154 154
Lines 7157 7165 +8
Branches 1420 1420
==========================================
Hits 6005 6005
- Misses 985 988 +3
- Partials 167 172 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed to work as intended manual, plus verified retry logic
JSErrors that happen multiple times throughout a page's life will now receive a timestamp unique to the agent harvest cycle instead of always reporting the timestamp of the first occurrence of that error.
Overview
Modified the JSErrors feature to cache the error timestamp per harvest cycle instead of per page lifecycle.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-261440
Testing