fix: JSEerrors harvest hasReplay decoration #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 83.80% 83.87% +0.06%
==========================================
Files 153 153
Lines 7151 7149 -2
Branches 1408 1413 +5
==========================================
+ Hits 5993 5996 +3
+ Misses 988 981 -7
- Partials 170 172 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
metal-messiah
approved these changes
Apr 18, 2024
|
Smoke test for chrome@latest passed after last change: https://github.com/newrelic/newrelic-browser-agent/actions/runs/8741381473/job/23987270890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where the SessionReplay feature was preloaded but a recording was never started, errors happening on the page would be improperly decorated with the
hasReplayflag.Overview
This introduces a pre-harvest cross-feature communication event within the JSErrors feature. When a harvest occurs, the JSErrors feature will send out the
cfc.jserrorsevent with an object containing information about the errors being harvested.The SessionReplay feature has been updated to listen to the
cfc.jserrorsevent and decorate the event payload with ahasReplayflag in the aggregate. The flag will be true only if the aggregate loaded, the aggregate has a running harvest scheduler, the aggregate has a recorder initialized, the mode is inFULL, the aggregate is not blocked, and the aggregate is entitled to harvest.A check as been added to the JSErrors
cfcfunction to check for the event data flaghasReplay. If any of the errors being harvested has thehasReplayflag present and truethy, but thecfcevent data is missing thehasReplayflag or the flag is falsey, the harvest payload will be updated to remove thehasReplayflag off all the error params objects.Note: If the
hasReplayflag is missing in thecfcevent data, it is indicative of the SessionReplay aggregate never loading. If it is present but has a false value, one of the above checks failed in the SessionReplay feature.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-260139
Testing
A wdio test was added that presents a reproducible scenario where the SessionReplay feature is preloaded but not auto started. In such a scenario, the errors harvested would always have
hasReplaybut shouldn't.