Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Soft navigations memory leak on harvest #979

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Apr 16, 2024

Address a couple scenarios of memory being not released by the soft navigation harvest cycle.

Overview

Release memory in the following scenarios (jest test cases):

  • when harvest is blocked (cors, adblock, etc.)
  • when harvest is fully successful

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-256262

Testing

Split 1 file into 2 + added

@cwli24 cwli24 changed the title fix: Soft navigation memory leak on harvest fix: Soft navigations memory leak on harvest Apr 16, 2024
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.17 kB / 10.93 kB (gzip) 31.17 kB / 10.93 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.56 kB / 16.71 kB (gzip) 51.56 kB / 16.71 kB (gzip) 0% / 0% (gzip)
pro loader 50.97 kB / 17.34 kB (gzip) 50.97 kB / 17.34 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 93.81 kB / 28.67 kB (gzip) 93.8 kB / 28.66 kB (gzip) -0.01% / -0.01% (gzip)
spa loader 59.53 kB / 19.93 kB (gzip) 59.53 kB / 19.93 kB (gzip) 0% / 0.02% (gzip)
spa async-chunk 108.28 kB / 32.88 kB (gzip) 108.28 kB / 32.88 kB (gzip) -0.01% / 0% (gzip)
lite-polyfills loader 125.13 kB / 40.22 kB (gzip) 125.13 kB / 40.22 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 66.25 kB / 19.05 kB (gzip) 66.25 kB / 19.05 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 145.35 kB / 46.23 kB (gzip) 145.35 kB / 46.22 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 128.77 kB / 33.53 kB (gzip) 128.74 kB / 33.52 kB (gzip) -0.02% / -0.04% (gzip)
spa-polyfills loader 153.38 kB / 48.36 kB (gzip) 153.38 kB / 48.36 kB (gzip) 0% / 0.01% (gzip)
spa-polyfills async-chunk 145.58 kB / 38.15 kB (gzip) 145.56 kB / 38.14 kB (gzip) -0.02% / -0.02% (gzip)

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (d6575bb) to head (ada9c5c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   83.80%   83.86%   +0.05%     
==========================================
  Files         153      153              
  Lines        7151     7151              
  Branches     1408     1408              
==========================================
+ Hits         5993     5997       +4     
+ Misses        988      985       -3     
+ Partials      170      169       -1     
Flag Coverage Δ
integration-tests 90.45% <ø> (+0.02%) ⬆️
unit-tests 67.44% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the one comment and tests.

Copy link

github-actions bot commented Apr 17, 2024

Static Badge

Last ran on April 17, 2024 13:15:26 CDT
Checking merge of (ada9c5c) into main (76d8fb2)

@cwli24 cwli24 merged commit 53bb120 into main Apr 18, 2024
49 of 51 checks passed
@cwli24 cwli24 deleted the fix-sn-ixn-awaiting branch April 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants