-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Soft navigations memory leak on harvest #979
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 83.80% 83.86% +0.05%
==========================================
Files 153 153
Lines 7151 7151
Branches 1408 1408
==========================================
+ Hits 5993 5997 +4
+ Misses 988 985 -3
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending the one comment and tests.
Address a couple scenarios of memory being not released by the soft navigation harvest cycle.
Overview
Release memory in the following scenarios (jest test cases):
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-256262
Testing
Split 1 file into 2 + added