Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust SR Timestamps to NR Server Time #939

Merged
merged 13 commits into from
Apr 4, 2024
Merged

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Apr 2, 2024

Adjust all timestamps sent as Session Replay event nodes to represent NR Server Time for accuracy in querying against adjacent but separate events in the timeline such as errors, page views, and interactions

Overview

This PR uses the TimeKeeper to adjust all SR event timestamps to reflect NR server time instead of local enduser machine time.

Related Issue(s)

NR-222416

Testing

Test cases have been added to the NR Server Time E2E test.

Copy link

github-actions bot commented Apr 2, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.1 kB / 10.87 kB (gzip) 31.1 kB / 10.87 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.35 kB / 16.66 kB (gzip) 51.35 kB / 16.66 kB (gzip) 0% / 0% (gzip)
pro loader 50.26 kB / 17.1 kB (gzip) 50.26 kB / 17.1 kB (gzip) 0% / -0.02% (gzip)
pro async-chunk 92.86 kB / 28.38 kB (gzip) 92.96 kB / 28.39 kB (gzip) 0.11% / 0.06% (gzip)
spa loader 58.83 kB / 19.69 kB (gzip) 58.83 kB / 19.69 kB (gzip) 0% / -0.01% (gzip)
spa async-chunk 107.33 kB / 32.62 kB (gzip) 107.44 kB / 32.62 kB (gzip) 0.09% / 0% (gzip)
lite-polyfills loader 125.13 kB / 40.19 kB (gzip) 125.13 kB / 40.19 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 66.04 kB / 18.99 kB (gzip) 66.04 kB / 18.99 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 145.15 kB / 46.11 kB (gzip) 145.15 kB / 46.11 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 128.49 kB / 33.44 kB (gzip) 128.49 kB / 33.44 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 153.18 kB / 48.26 kB (gzip) 153.18 kB / 48.26 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 145.3 kB / 38.05 kB (gzip) 145.3 kB / 38.05 kB (gzip) 0% / 0% (gzip)

Copy link

github-actions bot commented Apr 2, 2024

Static Badge

Last ran on April 03, 2024 22:26:56 CDT
Checking merge of (4cbcb8c) into main (19e076e)

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.75%. Comparing base (19e076e) to head (4cbcb8c).
Report is 1 commits behind head on main.

Files Patch % Lines
src/features/session_replay/shared/recorder.js 91.30% 2 Missing ⚠️
src/features/session_replay/aggregate/index.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   83.56%   83.75%   +0.18%     
==========================================
  Files         154      153       -1     
  Lines        7075     7102      +27     
  Branches     1396     1402       +6     
==========================================
+ Hits         5912     5948      +36     
+ Misses        992      986       -6     
+ Partials      171      168       -3     
Flag Coverage Δ
integration-tests 90.27% <84.21%> (+0.16%) ⬆️
unit-tests 67.04% <87.09%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah marked this pull request as draft April 2, 2024 14:01
@metal-messiah metal-messiah marked this pull request as ready for review April 2, 2024 16:57
Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just address the one comment and add the query parameter code.

@metal-messiah metal-messiah merged commit 94f0dee into main Apr 4, 2024
50 of 51 checks passed
@metal-messiah metal-messiah deleted the sr-timestamps branch April 4, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants