-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adjust SR Timestamps to NR Server Time #939
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
+ Coverage 83.56% 83.75% +0.18%
==========================================
Files 154 153 -1
Lines 7075 7102 +27
Branches 1396 1402 +6
==========================================
+ Hits 5912 5948 +36
+ Misses 992 986 -6
+ Partials 171 168 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just address the one comment and add the query parameter code.
Adjust all timestamps sent as Session Replay event nodes to represent NR Server Time for accuracy in querying against adjacent but separate events in the timeline such as errors, page views, and interactions
Overview
This PR uses the TimeKeeper to adjust all SR event timestamps to reflect NR server time instead of local enduser machine time.
Related Issue(s)
NR-222416
Testing
Test cases have been added to the NR Server Time E2E test.