-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass unload options to simultaneous harvests in Session Replay #870
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage ? 78.67%
=======================================
Files ? 145
Lines ? 6519
Branches ? 1267
=======================================
Hits ? 5129
Misses ? 1181
Partials ? 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pass unload options to simultaneous harvests in Session Replay to allow all calls to utilize sendBeacon when unloading
Overview
This should alleviate an issue where the page unloads before the agg has successfully sent preloaded payloads and creates a race condition between xhr and sendBeacon.
Related Issue(s)
Testing
All tests should continue to pass