Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass unload options to simultaneous harvests in Session Replay #870

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

metal-messiah
Copy link
Member

Pass unload options to simultaneous harvests in Session Replay to allow all calls to utilize sendBeacon when unloading

Overview

This should alleviate an issue where the page unloads before the agg has successfully sent preloaded payloads and creates a race condition between xhr and sendBeacon.

Related Issue(s)

Testing

All tests should continue to pass

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.46 kB / 10.66 kB (gzip) 30.46 kB / 10.66 kB (gzip) 0% / -0.02% (gzip)
lite async-chunk 45.86 kB / 15.1 kB (gzip) 45.86 kB / 15.1 kB (gzip) 0.02% / 0.01% (gzip)
pro loader 49.13 kB / 16.74 kB (gzip) 49.13 kB / 16.75 kB (gzip) 0% / 0.04% (gzip)
pro async-chunk 74.33 kB / 23.52 kB (gzip) 74.41 kB / 23.52 kB (gzip) 0.1% / 0% (gzip)
spa loader 55.6 kB / 18.72 kB (gzip) 55.6 kB / 18.73 kB (gzip) 0% / 0.01% (gzip)
spa async-chunk 89.1 kB / 27.89 kB (gzip) 89.18 kB / 27.91 kB (gzip) 0.09% / 0.05% (gzip)
lite-polyfills loader 125.12 kB / 39.91 kB (gzip) 125.12 kB / 39.91 kB (gzip) 0% / -0.01% (gzip)
lite-polyfills async-chunk 58.22 kB / 17.2 kB (gzip) 58.23 kB / 17.2 kB (gzip) 0.01% / 0.01% (gzip)
pro-polyfills loader 144.68 kB / 45.66 kB (gzip) 144.68 kB / 45.66 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.79 kB / 27.58 kB (gzip) 101.8 kB / 27.58 kB (gzip) 0.01% / 0% (gzip)
spa-polyfills loader 152.7 kB / 47.81 kB (gzip) 152.7 kB / 47.8 kB (gzip) 0% / -0.01% (gzip)
spa-polyfills async-chunk 117.35 kB / 32.56 kB (gzip) 117.36 kB / 32.56 kB (gzip) 0.01% / 0% (gzip)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@365e2d1). Click here to learn what that means.

❗ Current head 9e5c1af differs from pull request most recent head bfb5802. Consider uploading reports for the commit bfb5802 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage        ?   78.67%           
=======================================
  Files           ?      145           
  Lines           ?     6519           
  Branches        ?     1267           
=======================================
  Hits            ?     5129           
  Misses          ?     1181           
  Partials        ?      209           
Flag Coverage Δ
unit-tests 55.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 28, 2024

Static Badge

Last ran on January 27, 2024 21:41:52 CST
Checking merge of (a5ac843) into main (f69e4b0)

@metal-messiah
Copy link
Member Author

Firefox is being flaky with an unchanged stn test. Passes locally
image

@metal-messiah metal-messiah merged commit 655aa5d into main Jan 29, 2024
15 checks passed
@metal-messiah metal-messiah deleted the sr-bug-fix branch January 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants