fix: Fix issue with errors forcefully triggering session traces

[patrickhousley]

Fixing an issue where an uncaught error or calls to the noticeError API would force session trace to begin collecting and harvesting data, even though session trace and session replay were disabled via the RUM response.

Overview

With the recent session replay API merge, an error thrown on a page or passed in using the noticeError API method would cause session trace to switch to full mode. This was due to session trace not accounting for the current session replay mode when switching modes. If session replay is disabled, session trace should not switch modes at all from it's initial mode.

Related Issue(s)

https://newrelic.pagerduty.com/incidents/Q05RP88T92MSAS/

#803

Testing

Full suite passed locally. Seeking merge due to time constraints for active incident

[github-actions]

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent	Asset	Previous Size	New Size	Diff
lite	loader	31.05 kB / 10.54 kB (gzip)	31.05 kB / 10.54 kB (gzip)	0% / 0% (gzip)
lite	async-chunk	45.58 kB / 15.05 kB (gzip)	45.58 kB / 15.05 kB (gzip)	0% / 0% (gzip)
pro	loader	48.46 kB / 15.96 kB (gzip)	48.46 kB / 15.96 kB (gzip)	0% / -0.01% (gzip)
pro	async-chunk	74.41 kB / 23.67 kB (gzip)	74.48 kB / 23.68 kB (gzip)	0.09% / 0.03% (gzip)
spa	loader	54.91 kB / 17.94 kB (gzip)	54.91 kB / 17.94 kB (gzip)	0% / 0.01% (gzip)
spa	async-chunk	89.18 kB / 28.13 kB (gzip)	89.25 kB / 28.13 kB (gzip)	0.07% / 0.02% (gzip)
lite-polyfills	loader	122.57 kB / 39.55 kB (gzip)	122.57 kB / 39.55 kB (gzip)	0% / 0% (gzip)
lite-polyfills	async-chunk	57.97 kB / 17.26 kB (gzip)	57.97 kB / 17.26 kB (gzip)	0% / 0% (gzip)
pro-polyfills	loader	142.09 kB / 45.42 kB (gzip)	142.09 kB / 45.42 kB (gzip)	0% / 0% (gzip)
pro-polyfills	async-chunk	101.62 kB / 27.31 kB (gzip)	101.74 kB / 27.33 kB (gzip)	0.12% / 0.1% (gzip)
spa-polyfills	loader	150.11 kB / 47.55 kB (gzip)	150.11 kB / 47.55 kB (gzip)	0% / 0% (gzip)
spa-polyfills	async-chunk	117.19 kB / 31.9 kB (gzip)	117.31 kB / 31.92 kB (gzip)	0.1% / 0.08% (gzip)

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (453c380) 78.29% compared to head (01f7e29) 78.28%.

Files	Patch %	Lines
src/features/session_trace/aggregate/index.js	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   78.29%   78.28%   -0.02%     
==========================================
  Files         142      142              
  Lines        6349     6350       +1     
  Branches     1227     1228       +1     
==========================================
  Hits         4971     4971              
  Misses       1166     1166              
- Partials      212      213       +1     

Flag	Coverage Δ
unit-tests	55.10% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.