Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report enduser.id with Session Replay #815

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: Report enduser.id with Session Replay #815

merged 2 commits into from
Nov 15, 2023

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Nov 14, 2023

Report enduser.id if set with Session Replay data to improve faceting the Session Replay UX

Overview

This PR adds the enduser id to outgoing SR payloads to help facilitate increased faceting in Session Replay UXs.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-180218

Testing

Copy link

github-actions bot commented Nov 14, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.05 kB / 10.54 kB (gzip) 31.05 kB / 10.54 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.58 kB / 15.05 kB (gzip) 45.58 kB / 15.05 kB (gzip) 0% / 0% (gzip)
pro loader 48.46 kB / 15.96 kB (gzip) 48.46 kB / 15.96 kB (gzip) 0% / 0.02% (gzip)
pro async-chunk 74.38 kB / 23.65 kB (gzip) 74.41 kB / 23.67 kB (gzip) 0.04% / 0.11% (gzip)
spa loader 54.91 kB / 17.94 kB (gzip) 54.91 kB / 17.94 kB (gzip) 0% / -0.01% (gzip)
spa async-chunk 88.87 kB / 28.01 kB (gzip) 88.9 kB / 28.03 kB (gzip) 0.03% / 0.09% (gzip)
lite-polyfills loader 122.57 kB / 39.55 kB (gzip) 122.57 kB / 39.55 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.97 kB / 17.26 kB (gzip) 57.97 kB / 17.26 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 142.09 kB / 45.42 kB (gzip) 142.09 kB / 45.42 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.62 kB / 27.31 kB (gzip) 101.62 kB / 27.31 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 150.11 kB / 47.55 kB (gzip) 150.11 kB / 47.55 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 116.79 kB / 31.76 kB (gzip) 116.79 kB / 31.76 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12eb453) 78.40% compared to head (d8fed74) 78.29%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   78.40%   78.29%   -0.11%     
==========================================
  Files         142      142              
  Lines        6335     6345      +10     
  Branches     1223     1225       +2     
==========================================
+ Hits         4967     4968       +1     
- Misses       1158     1168      +10     
+ Partials      210      209       -1     
Flag Coverage Δ
unit-tests 55.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to spec update PR pls

Copy link

github-actions bot commented Nov 15, 2023

Static Badge

Last ran on November 15, 2023 11:53:03 CST
Checking merge of (e4e4577) into main (2eb7e28)

@metal-messiah
Copy link
Member Author

@metal-messiah metal-messiah merged commit 8f5446d into main Nov 15, 2023
13 of 14 checks passed
@metal-messiah metal-messiah deleted the sr-userid branch November 15, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants