feat: Ensure 15 second minimum error buffer when possible #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a two-step sliding window to ensure 15-30 second buffer time for applicable error replays
Overview
The previous implementation had the possibility to harvest shortly after a new checkout, leading to a very short error buffer. The two-step sliding window will ensure that the shortest buffer in that scenario would be 15s instead of 0.
Related Issue(s)
https://issues.newrelic.com/browse/NR-125668
Testing
Existing tests should continue to pass, as the only thing this changes is the minimum length of the buffer in the case of subsequent checkouts