Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure 15 second minimum error buffer when possible #759

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Oct 5, 2023

Add a two-step sliding window to ensure 15-30 second buffer time for applicable error replays

Overview

The previous implementation had the possibility to harvest shortly after a new checkout, leading to a very short error buffer. The two-step sliding window will ensure that the shortest buffer in that scenario would be 15s instead of 0.

Related Issue(s)

https://issues.newrelic.com/browse/NR-125668

Testing

Existing tests should continue to pass, as the only thing this changes is the minimum length of the buffer in the case of subsequent checkouts

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.3 kB / 10.13 kB (gzip) 29.3 kB / 10.13 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.37 kB / 14.99 kB (gzip) 45.37 kB / 14.99 kB (gzip) 0% / 0% (gzip)
pro loader 46.7 kB / 15.6 kB (gzip) 46.7 kB / 15.6 kB (gzip) 0% / 0% (gzip)
pro async-chunk 71.61 kB / 22.86 kB (gzip) 71.83 kB / 22.91 kB (gzip) 0.29% / 0.21% (gzip)
spa loader 53.12 kB / 17.57 kB (gzip) 53.12 kB / 17.57 kB (gzip) 0% / 0% (gzip)
spa async-chunk 85.84 kB / 27.14 kB (gzip) 86.05 kB / 27.19 kB (gzip) 0.25% / 0.2% (gzip)
lite-polyfills loader 99.81 kB / 31.78 kB (gzip) 99.81 kB / 31.78 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.81 kB / 17.21 kB (gzip) 57.81 kB / 17.21 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 119.4 kB / 37.73 kB (gzip) 119.4 kB / 37.73 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 98.94 kB / 26.66 kB (gzip) 98.94 kB / 26.66 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 127.37 kB / 39.86 kB (gzip) 127.37 kB / 39.86 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 113.82 kB / 31.06 kB (gzip) 113.82 kB / 31.06 kB (gzip) 0% / 0% (gzip)
worker loader 41.41 kB / 14 kB (gzip) 41.41 kB / 14 kB (gzip) 0% / 0% (gzip)
worker async-chunk 45.45 kB / 15.34 kB (gzip) 45.45 kB / 15.34 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #759 (75d3a9c) into main (51678d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   87.64%   87.65%           
=======================================
  Files         135      135           
  Lines        5486     5490    +4     
  Branches      869      872    +3     
=======================================
+ Hits         4808     4812    +4     
  Misses        621      621           
  Partials       57       57           
Flag Coverage Δ
unit-tests 80.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/features/session_replay/aggregate/index.js 95.70% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@metal-messiah metal-messiah merged commit 8506803 into main Oct 5, 2023
15 checks passed
@metal-messiah metal-messiah deleted the error-buffer branch October 5, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants