Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-update assets proxy to accept host URL strings #752

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Oct 4, 2023

Tweaks the feature added in v1.240.0 wherein the agent code became proxy-able. It worked correctly in expecting that the protocol (i.e. https://) is included in the configuration input, but we have since decided that it can be excluded in conformity with the proxy beacon field that only accepts a host string.

Overview

Both proxy.beacon and proxy.assets should follow the format <hostname>[:<port>] now, without protocol specified (will default to https).

Related Issue(s)

#659

Testing

Existing proxy.e2e.js suffices.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Static Badge

Last ran on October 03, 2023 19:43:39 CDT
Checking merge of (41c6b21) into main (70a896b)

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.25 kB / 10.1 kB (gzip) 29.3 kB / 10.13 kB (gzip) 0.16% / 0.23% (gzip)
lite async-chunk 45.37 kB / 14.99 kB (gzip) 45.37 kB / 14.99 kB (gzip) 0% / 0% (gzip)
pro loader 46.66 kB / 15.58 kB (gzip) 46.7 kB / 15.6 kB (gzip) 0.1% / 0.13% (gzip)
pro async-chunk 71.61 kB / 22.86 kB (gzip) 71.61 kB / 22.86 kB (gzip) 0% / 0% (gzip)
spa loader 53.07 kB / 17.55 kB (gzip) 53.12 kB / 17.57 kB (gzip) 0.09% / 0.13% (gzip)
spa async-chunk 85.83 kB / 27.15 kB (gzip) 85.83 kB / 27.15 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 99.77 kB / 31.75 kB (gzip) 99.81 kB / 31.78 kB (gzip) 0.05% / 0.09% (gzip)
lite-polyfills async-chunk 57.81 kB / 17.21 kB (gzip) 57.81 kB / 17.21 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 119.35 kB / 37.7 kB (gzip) 119.4 kB / 37.73 kB (gzip) 0.04% / 0.06% (gzip)
pro-polyfills async-chunk 98.94 kB / 26.66 kB (gzip) 98.94 kB / 26.66 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 127.33 kB / 39.84 kB (gzip) 127.37 kB / 39.86 kB (gzip) 0.04% / 0.05% (gzip)
spa-polyfills async-chunk 113.82 kB / 31.06 kB (gzip) 113.82 kB / 31.06 kB (gzip) 0% / 0% (gzip)
worker loader 41.36 kB / 13.98 kB (gzip) 41.41 kB / 14 kB (gzip) 0.11% / 0.14% (gzip)
worker async-chunk 45.45 kB / 15.34 kB (gzip) 45.45 kB / 15.34 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #752 (41c6b21) into main (70a896b) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   87.61%   87.62%           
=======================================
  Files         135      135           
  Lines        5484     5486    +2     
  Branches      868      869    +1     
=======================================
+ Hits         4805     4807    +2     
  Misses        622      622           
  Partials       57       57           
Flag Coverage Δ
integration-tests 87.50% <80.00%> (+<0.01%) ⬆️
unit-tests 80.56% <20.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/loaders/configure/public-path.js 100.00% <100.00%> (ø)
src/loaders/configure/configure.js 86.95% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cwli24 cwli24 merged commit a7f58a3 into main Oct 4, 2023
44 of 46 checks passed
@cwli24 cwli24 deleted the redo-asset-proxy branch October 4, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants