fix: Re-update assets proxy to accept host URL strings #752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the feature added in v1.240.0 wherein the agent code became proxy-able. It worked correctly in expecting that the protocol (i.e.
https://
) is included in the configuration input, but we have since decided that it can be excluded in conformity with the proxy beacon field that only accepts a host string.Overview
Both proxy.beacon and proxy.assets should follow the format
<hostname>[:<port>]
now, without protocol specified (will default to https).Related Issue(s)
#659
Testing
Existing proxy.e2e.js suffices.