Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated API inlineHit #744

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

patrickhousley
Copy link
Contributor

Removing the browser agent API inlineHit. This API was deprecated in 2014 and is no longer supported or used by newer versions of the browser agent.

Overview

Removing the deprecated inlineHit api.

Related Issue(s)

https://issues.newrelic.com/browse/NR-166453

Testing

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Static Badge

Last ran on October 02, 2023 08:41:43 CDT
Checking merge of (cb2b71e) into main (f0d3fe4)

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.33 kB / 10.13 kB (gzip) 29.31 kB / 10.12 kB (gzip) -0.08% / -0.1% (gzip)
lite async-chunk 45.53 kB / 15.1 kB (gzip) 45.09 kB / 14.89 kB (gzip) -0.96% / -1.36% (gzip)
pro loader 46.74 kB / 15.6 kB (gzip) 46.71 kB / 15.59 kB (gzip) -0.05% / -0.07% (gzip)
pro async-chunk 166.12 kB / 52.32 kB (gzip) 166.12 kB / 52.32 kB (gzip) 0% / 0% (gzip)
spa loader 53.15 kB / 17.57 kB (gzip) 53.13 kB / 17.56 kB (gzip) -0.05% / -0.05% (gzip)
spa async-chunk 166.12 kB / 52.32 kB (gzip) 166.12 kB / 52.32 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 99.85 kB / 31.78 kB (gzip) 99.82 kB / 31.77 kB (gzip) -0.02% / -0.03% (gzip)
lite-polyfills async-chunk 57.96 kB / 17.32 kB (gzip) 57.53 kB / 17.1 kB (gzip) -0.75% / -1.25% (gzip)
pro-polyfills loader 119.43 kB / 37.73 kB (gzip) 119.41 kB / 37.72 kB (gzip) -0.02% / -0.02% (gzip)
pro-polyfills async-chunk 99.09 kB / 26.77 kB (gzip) 98.66 kB / 26.55 kB (gzip) -0.44% / -0.84% (gzip)
spa-polyfills loader 127.41 kB / 39.86 kB (gzip) 127.39 kB / 39.85 kB (gzip) -0.02% / -0.03% (gzip)
spa-polyfills async-chunk 113.98 kB / 31.16 kB (gzip) 113.54 kB / 30.94 kB (gzip) -0.38% / -0.7% (gzip)
worker loader 41.44 kB / 14 kB (gzip) 41.42 kB / 13.99 kB (gzip) -0.06% / -0.07% (gzip)
worker async-chunk 45.59 kB / 15.46 kB (gzip) 45.17 kB / 15.25 kB (gzip) -0.91% / -1.31% (gzip)

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #744 (cb2b71e) into main (f0d3fe4) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   86.90%   87.19%   +0.28%     
==========================================
  Files         135      135              
  Lines        5331     5310      -21     
  Branches      736      732       -4     
==========================================
- Hits         4633     4630       -3     
+ Misses        636      620      -16     
+ Partials       62       60       -2     
Flag Coverage Δ
integration-tests 87.48% <100.00%> (+0.34%) ⬆️
unit-tests 80.49% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/loaders/api/api.js 74.46% <100.00%> (-1.62%) ⬇️
src/loaders/api/apiAsync.js 60.71% <ø> (+24.17%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 if we got PM go-ahead already.

@patrickhousley
Copy link
Contributor Author

@patrickhousley patrickhousley merged commit 54b42ea into main Oct 2, 2023
46 checks passed
@patrickhousley patrickhousley deleted the remove-inlineHit branch October 2, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants