-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust Session Replay meta and timestamps #743
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 87.90% 87.98% +0.08%
==========================================
Files 135 135
Lines 5299 5302 +3
Branches 733 732 -1
==========================================
+ Hits 4658 4665 +7
+ Misses 591 588 -3
+ Partials 50 49 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending comment about the payload still containing meta nodes even if the last node is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to fix merge conflicts and run test suite.
PR checks passing, so merging |
Ensure that payloads can not ends with a meta node or start with a snapshot node for consistency in UI render queries
Overview
This PR ensures that payloads can not end with a meta node or start with a snapshot node. Tangentially, it helps align timestamps better when nodes have to be shifted around across payloads.
Related Issue(s)
Testing
Existing tests should continue to pass