Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust Session Replay meta and timestamps #743

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 29, 2023

Ensure that payloads can not ends with a meta node or start with a snapshot node for consistency in UI render queries

Overview

This PR ensures that payloads can not end with a meta node or start with a snapshot node. Tangentially, it helps align timestamps better when nodes have to be shifted around across payloads.

Related Issue(s)

Testing

Existing tests should continue to pass

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.31 kB / 10.12 kB (gzip) 29.31 kB / 10.12 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.09 kB / 14.89 kB (gzip) 45.09 kB / 14.89 kB (gzip) 0% / 0% (gzip)
pro loader 46.71 kB / 15.59 kB (gzip) 46.71 kB / 15.59 kB (gzip) 0% / 0% (gzip)
pro async-chunk 70.86 kB / 22.57 kB (gzip) 71.01 kB / 22.64 kB (gzip) 0.21% / 0.33% (gzip)
spa loader 53.13 kB / 17.56 kB (gzip) 53.13 kB / 17.56 kB (gzip) 0% / 0% (gzip)
spa async-chunk 85.09 kB / 26.85 kB (gzip) 85.24 kB / 26.92 kB (gzip) 0.18% / 0.25% (gzip)
lite-polyfills loader 99.82 kB / 31.77 kB (gzip) 99.82 kB / 31.77 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.53 kB / 17.1 kB (gzip) 57.53 kB / 17.1 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 119.41 kB / 37.72 kB (gzip) 119.41 kB / 37.72 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 98.66 kB / 26.55 kB (gzip) 98.66 kB / 26.55 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 127.39 kB / 39.85 kB (gzip) 127.39 kB / 39.85 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 113.54 kB / 30.94 kB (gzip) 113.54 kB / 30.94 kB (gzip) 0% / 0% (gzip)
worker loader 41.42 kB / 13.99 kB (gzip) 41.42 kB / 13.99 kB (gzip) 0% / 0% (gzip)
worker async-chunk 45.17 kB / 15.25 kB (gzip) 45.17 kB / 15.25 kB (gzip) 0% / 0% (gzip)

@metal-messiah metal-messiah marked this pull request as ready for review September 29, 2023 13:34
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #743 (b5f040f) into main (e6c0a1a) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   87.90%   87.98%   +0.08%     
==========================================
  Files         135      135              
  Lines        5299     5302       +3     
  Branches      733      732       -1     
==========================================
+ Hits         4658     4665       +7     
+ Misses        591      588       -3     
+ Partials       50       49       -1     
Flag Coverage Δ
integration-tests 87.48% <81.25%> (-0.01%) ⬇️
unit-tests 82.64% <76.19%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/features/session_replay/aggregate/index.js 96.47% <89.28%> (+1.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Static Badge

Last ran on October 03, 2023 16:09:22 CDT
Checking merge of (b5f040f) into main (e6c0a1a)

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comment about the payload still containing meta nodes even if the last node is removed.

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to fix merge conflicts and run test suite.

@metal-messiah
Copy link
Member Author

PR checks passing, so merging

@metal-messiah metal-messiah merged commit ed727c6 into main Oct 3, 2023
46 checks passed
@metal-messiah metal-messiah deleted the sr-meta-bug branch October 3, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants