fix: Fix serialization issue with array data #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 130 130
Lines 6017 6017
Branches 1140 1140
=======================================
Hits 4094 4094
Misses 1579 1579
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
patrickhousley
approved these changes
Jul 27, 2023
|
Circle back and diagnose IE11 issues on unit tests (JIL) |
metal-messiah
added
the
needs follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the harvester to account for array payloads, which in niche cases could convert array payloads to indexed objects.
Overview
This PR updates the cleanPayload mechanics to account for array payloads.
Related Issue(s)
NR-143331
Testing
Session replay wdio tests + harvest.test.js should continue to pass