feat: Add warning for large payloads #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 66.64% 66.66% +0.02%
==========================================
Files 130 130
Lines 6011 6018 +7
Branches 1141 1142 +1
==========================================
+ Hits 4006 4012 +6
- Misses 1641 1642 +1
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cwli24
reviewed
Jul 19, 2023
cwli24
reviewed
Jul 19, 2023
patrickhousley
approved these changes
Jul 27, 2023
|
Should follow up with plan about surfacing "warnings" to NR1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning for large payloads, which is typically caused by excessive custom attribute sizes.
Overview
This PR adds a check to the harvest cycle to check the body size. If the body is large (>750kb), it will log a warning to the console noting that customers should check their custom attributes.
Related Issue(s)
NR-137463
Testing
A new jest test representing this case has been added to
harvest.test.js