feat: Stop reporting ajax events going to same beacon #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwli24
added
enhancement
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 66.67% 67.69% +1.02%
==========================================
Files 130 130
Lines 6008 6012 +4
Branches 1139 1149 +10
==========================================
+ Hits 4006 4070 +64
+ Misses 1639 1595 -44
+ Partials 363 347 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Lets merge with main and run all wdio tests, but otherwise looks good |
metal-messiah
approved these changes
Jul 27, 2023
metal-messiah
added
the
needs follow up
metal-messiah
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network requests made to the same hostname as the agent's reporting beacon endpoint are no longer captured, by default. As an example, outgoing XHRs to the
bam.nr-data.netURL where analytic data is typically sent would not reflectively record itself.Overview
Primary purpose is to make "internal URL" reporting dynamic, so that when the beacon url is changed each time, the
deny_listsetting doesn't also have to change to retain the block. In other words, it's no longer necessary to includebam-cell.nr-data.net, etc. in the deny_list to prevent agent from reporting its own generated traffic by simply toggling the flag.This also helps facilitate users who don't care about the agent's own reporting from showing on their NR1 dashboard and from being billed for such data.
Related Issue(s)
NR-99149, NR-136392
Bug: NR-140471
Testing
Verify that ajax events are not sent for network requests going to any domain that
info.beaconorinfo.errorBeaconis also set to, wheninit.ajax.block_internal = true(default), but they then are when the flag is flipped to befalse.Also check that whether the initial
init.ajax.deny_listis undefined or a preset list doesn't affect this behavior.