fix: Address bug affecting XHR harvest re-schedule #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 19.97% 19.95% -0.02%
==========================================
Files 132 132
Lines 4326 4329 +3
Branches 1103 1104 +1
==========================================
Hits 864 864
- Misses 2735 2737 +2
- Partials 727 728 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
patrickhousley
approved these changes
May 31, 2023
cwli24
reviewed
May 31, 2023
cwli24
reviewed
May 31, 2023
cwli24
added
bug
cwli24
approved these changes
May 31, 2023
bjfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A early return condition in the harvest rescheduling logic in version 1.233.0 was preventing Ajax event harvest from being rescheduled in cases where no data had accumulated.
Overview
This PR addresses a problem where, once the harvest scheduler runs for the Ajax feature and the Ajax feature has no accumulated data, the Ajax feature no longer performs future harvests. The issue appears to be line 92 in the harvest scheduler where it early-returns when there is no data to send, but does not schedule the next harvest.
Related Issue(s)
NEWRELIC-8876
Testing
npm test src/common/harvest/harvest-scheduler.test.js