-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update agent internals in early preparation for new features #532
Conversation
…ession manager for easier unit testing
Passing test with testing architecture changes --> https://github.com/newrelic/newrelic-browser-agent/actions/runs/5040202999 Workers run on cron job |
Co-authored-by: Ben Field <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the session replay feature does not load in the agent.
Test run after fixing merge conflicts --> https://github.com/newrelic/newrelic-browser-agent/actions/runs/5069516312 |
* Capture metrics for usage of MooTools and certain polyfills (#539) (903a7e1) * Update agent internals in early preparation for new features (#532) (1ee675d) * Address "configurable" warnings arising from user-agent module (#546) (7a7dace) * Ensure runtime is preserved for late-configuration cases (#538) (229b8ed) * Refactor usage of Array.from to address MooTools conflict (#544) (f1e6336)
* Capture metrics for usage of MooTools and certain polyfills (#539) (903a7e1) * Update agent internals in early preparation for new features (#532) (1ee675d) * Address "configurable" warnings arising from user-agent module (#546) (7a7dace) * Ensure runtime is preserved for late-configuration cases (#538) (229b8ed) * Refactor usage of Array.from to address MooTools conflict (#544) (f1e6336)
The agent code base now contains the non-functional foundations of session replay mechanics. Note that this code is dormant and disabled. It will not download or execute until the session replay feature and its downstream dependencies are in a finished state.
Overview
This PR contains internal changes to support upcoming features, and introduces some [WIP] feature modules. These modules will not be included in any agent builds until a complete UX is designed and implemented.
Important notes:
sr: 1
.Related Issue(s)
Testing
Testing has not been adapted to this feature yet. Along with the tests themselves, testing architecture needs to be added to support this feature, namely mock route handling for the
/blob
endpoint.