fix: Soft navigation bug fixes and new soft navigation tests #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 89.03% 89.05% +0.02%
==========================================
Files 170 170
Lines 7416 7422 +6
Branches 1493 1496 +3
==========================================
+ Hits 6603 6610 +7
+ Misses 692 690 -2
- Partials 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ellisong
force-pushed
the
translate-spa-tests
branch
2 times, most recently
from
abd1e4d to
6225ce0
Compare
ptang-nr
reviewed
Dec 13, 2024
ellisong
force-pushed
the
translate-spa-tests
branch
from
5350df6 to
3a62877
Compare
ptang-nr
approved these changes
Dec 17, 2024
|
Since this will show up in the release notes and changelog -- Can you update the PR title to reflect what specific bugs were addressed with this work and target that description to be more of a "bug fix" description |
ellisong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues tied to the soft navigations feature. Calling newrelic.interaction() prior to a page load now creates a separate "api" trigger node. Multiple interactions managed simultaneously now have correct timings. Fixes a bug in soft navigation where API-triggered interactions fail to close under default heuristic (URL + DOM change) because the mutation observer is not started. Finally, 'popstate' events are now valid interaction triggers for soft navigations.
Overview
Fixes a few bugs related to the soft navigation feature and adds new tests ported from the old spa feature. Not all of the tests are portable due to functional differences or limitations.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-300966
bug: https://new-relic.atlassian.net/browse/NR-343675
Testing
Make sure all tests pass on all browsers.