-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multiple MicroAgent undefined session and limit available API #1252
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
+ Coverage 89.08% 89.21% +0.12%
==========================================
Files 169 170 +1
Lines 7351 7331 -20
Branches 1476 1476
==========================================
- Hits 6549 6540 -9
+ Misses 682 671 -11
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
MicroAgent class now only shows the relevant API for use with NPM. The set is limited to methods that relate to features available with the MicroAgent. An issue with missing session when multiple MicroAgents are initialized is also fixed.
Overview
MicroAgent is trimmed down to the 10 methods, including
start
, that are relevant. The full set ofapi.js
is still imported and set, but the public interface or users' IDE will not list the other methods used by non-MicroAgent features.Previously, when initializing more than one MicroAgent, the session object remains undefined on the second and onward instances, causing only one of multiple MicroAgent to have/report a session. This is fixed here so now all microagent will have a valid session of the same session ID.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-289146
https://new-relic.atlassian.net/browse/NR-328644
Testing