Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove 'pageHide' from page end-of-lifecycle listener #1219

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

ptang-nr
Copy link
Contributor

@ptang-nr ptang-nr commented Oct 15, 2024

Remove pageHide from page end-of-lifecycle listener since browser agent support for Safari 14.4 is deprecated

Overview

Previously in support of Safari 14.4, we had retained the subscription to pageHide event for detecting when a page is entering a hidden state. Safari 14.4 has now aged out of our current supported versions, so we are removing the pageHide logic. Page unloads should now be detected via visibilitychange events across all supported browsers.

Related Issue(s)

NR-292875

Testing

Ran final-harvesting.e2e.js to ensure tests are passing
Run pull-request-checks on PR branch to ensure everything still passes <-- ISSUES FOUND (TODO)

Copy link

github-actions bot commented Oct 15, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.48 kB / 11.03 kB (gzip) 30.48 kB / 11.03 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 51.58 kB / 16.74 kB (gzip) 51.51 kB / 16.72 kB (gzip) -0.14% / -0.15% (gzip)
pro loader 51.5 kB / 17.8 kB (gzip) 51.5 kB / 17.8 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 100.6 kB / 30.83 kB (gzip) 100.53 kB / 30.8 kB (gzip) -0.07% / -0.1% (gzip)
spa loader 59.16 kB / 20.17 kB (gzip) 59.16 kB / 20.16 kB (gzip) 0% / -0.01% (gzip)
spa async-chunk 115.66 kB / 35.18 kB (gzip) 115.59 kB / 35.15 kB (gzip) -0.06% / -0.09% (gzip)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (90a16c4) to head (bc3a870).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   88.67%   88.68%           
=======================================
  Files         169      169           
  Lines        7375     7371    -4     
  Branches     1507     1507           
=======================================
- Hits         6540     6537    -3     
+ Misses        716      714    -2     
- Partials      119      120    +1     
Flag Coverage Δ
integration-tests 91.75% <100.00%> (-0.03%) ⬇️
unit-tests 79.34% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptang-nr ptang-nr marked this pull request as ready for review October 15, 2024 22:26
Copy link

github-actions bot commented Oct 15, 2024

Static Badge

Last ran on October 17, 2024 16:35:04 CDT
Checking merge of (bc3a870) into main (90a16c4)

@cwli24 cwli24 merged commit daf349e into main Oct 17, 2024
30 of 32 checks passed
@cwli24 cwli24 deleted the NR-292875/remove-pageHide-from-eol-listener branch October 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants