-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove 'pageHide' from page end-of-lifecycle listener #1219
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 88.67% 88.68%
=======================================
Files 169 169
Lines 7375 7371 -4
Branches 1507 1507
=======================================
- Hits 6540 6537 -3
+ Misses 716 714 -2
- Partials 119 120 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove
pageHide
from page end-of-lifecycle listener since browser agent support for Safari 14.4 is deprecatedOverview
Previously in support of Safari 14.4, we had retained the subscription to
pageHide
event for detecting when a page is entering a hidden state. Safari 14.4 has now aged out of our current supported versions, so we are removing thepageHide
logic. Page unloads should now be detected viavisibilitychange
events across all supported browsers.Related Issue(s)
NR-292875
Testing
Ran
final-harvesting.e2e.js
to ensure tests are passingRun pull-request-checks on PR branch to ensure everything still passes <-- ISSUES FOUND (TODO)