Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add instrumentation metadata to logging #1208

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Oct 7, 2024

Add instrumentation attribution to logging payloads to fortify categorization and billing calculations in New Relic platforms. These attributes are dropped during processing and before storing the data and as such do not affect customer billing rates.

Overview

Added internal instrumentation attribution which helps the billing mechanisms categorize incoming data. The data is dropped before storing in NR1 and does not affect billing. See the linked ticket for more context.

Related Issue(s)

NR-312582

Testing

Tests have been updated to check for the new attributes

Copy link

github-actions bot commented Oct 7, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.48 kB / 11.03 kB (gzip) 30.48 kB / 11.03 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.58 kB / 16.74 kB (gzip) 51.58 kB / 16.74 kB (gzip) 0% / 0% (gzip)
pro loader 51.5 kB / 17.8 kB (gzip) 51.5 kB / 17.8 kB (gzip) 0% / -0.02% (gzip)
pro async-chunk 99.87 kB / 30.5 kB (gzip) 100 kB / 30.55 kB (gzip) 0.13% / 0.14% (gzip)
spa loader 59.16 kB / 20.16 kB (gzip) 59.16 kB / 20.16 kB (gzip) 0% / -0.02% (gzip)
spa async-chunk 114.93 kB / 34.86 kB (gzip) 115.06 kB / 34.9 kB (gzip) 0.11% / 0.12% (gzip)

Copy link

github-actions bot commented Oct 7, 2024

Static Badge

Last ran on October 08, 2024 16:57:45 CDT
Checking merge of (99ad2c0) into main (c8c9165)

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (c8c9165) to head (99ad2c0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files         168      168           
  Lines        7334     7336    +2     
  Branches     1502     1502           
=======================================
+ Hits         6498     6500    +2     
  Misses        713      713           
  Partials      123      123           
Flag Coverage Δ
unit-tests 78.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 changed the title feat: add instrumentation metadata feat: Add instrumentation metadata Oct 10, 2024
@cwli24 cwli24 changed the title feat: Add instrumentation metadata feat: Add instrumentation metadata to logging Oct 10, 2024
@metal-messiah metal-messiah merged commit 6926474 into main Oct 11, 2024
33 of 34 checks passed
@metal-messiah metal-messiah deleted the logging-decorators branch October 11, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants