-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent agent using invalid date header #1122
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 87.83% 87.70% -0.13%
==========================================
Files 162 162
Lines 7267 7282 +15
Branches 1428 1435 +7
==========================================
+ Hits 6383 6387 +4
- Misses 766 773 +7
- Partials 118 122 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8c6db74
to
bb76965
Compare
Shut down the agent when unable to read a correctly formatted date header for the page view event harvest. This prevents harvesting data with wildly inaccurate timestamps. This should only happen with third-party or non-agent code has tampered with the ajax response headers.
Overview
Adding supportability metrics to track when the calculated time diff is >= 12 hours, >= 6 hours, or >= 1 hour.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-295258
https://source.datanerd.us/agents/angler/pull/600
Testing