Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create generic events feature #1121

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jul 23, 2024

Create a feature that will normalize, aggregate and harvest all generic events.

Related Issue(s)

NR-291171

Testing

Feature testing to be added when real data begins flowing through the new feature

Copy link

github-actions bot commented Jul 23, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.44 kB / 11.33 kB (gzip) 32.56 kB / 11.36 kB (gzip) 0.35% / 0.26% (gzip)
lite async-chunk 50.9 kB / 16.39 kB (gzip) 51.13 kB / 16.41 kB (gzip) 0.46% / 0.12% (gzip)
pro loader 53.3 kB / 18.04 kB (gzip) 53.68 kB / 18.1 kB (gzip) 0.71% / 0.32% (gzip)
pro async-chunk 97.12 kB / 29.04 kB (gzip) 99.29 kB / 29.59 kB (gzip) 2.23% / 1.9% (gzip)
spa loader 61.24 kB / 20.48 kB (gzip) 61.62 kB / 20.55 kB (gzip) 0.62% / 0.34% (gzip)
spa async-chunk 112.18 kB / 33.37 kB (gzip) 114.34 kB / 33.92 kB (gzip) 1.93% / 1.66% (gzip)
lite-polyfills loader 125.99 kB / 40.62 kB (gzip) 126.1 kB / 40.65 kB (gzip) 0.09% / 0.07% (gzip)
lite-polyfills async-chunk 64.99 kB / 18.73 kB (gzip) 65.22 kB / 18.76 kB (gzip) 0.35% / 0.16% (gzip)
pro-polyfills loader 148.55 kB / 46.95 kB (gzip) 149.15 kB / 47.03 kB (gzip) 0.4% / 0.17% (gzip)
pro-polyfills async-chunk 117.32 kB / 31.32 kB (gzip) 121.39 kB / 31.96 kB (gzip) 3.47% / 2.05% (gzip)
spa-polyfills loader 156.75 kB / 49.11 kB (gzip) 157.35 kB / 49.19 kB (gzip) 0.38% / 0.18% (gzip)
spa-polyfills async-chunk 134.23 kB / 35.99 kB (gzip) 138.3 kB / 36.63 kB (gzip) 3.04% / 1.78% (gzip)

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 38.66667% with 46 lines in your changes missing coverage. Please review.

Project coverage is 87.26%. Comparing base (edc20d4) to head (dd7fca5).
Report is 3 commits behind head on main.

Files Patch % Lines
src/features/generic_events/aggregate/index.js 32.30% 34 Missing and 10 partials ⚠️
src/features/utils/aggregate-base.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   87.79%   87.26%   -0.53%     
==========================================
  Files         162      165       +3     
  Lines        7265     7358      +93     
  Branches     1426     1452      +26     
==========================================
+ Hits         6378     6421      +43     
- Misses        770      809      +39     
- Partials      117      128      +11     
Flag Coverage Δ
unit-tests 75.48% <5.55%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing package.json updates for this feature and for soft nav. Should also update the npm tests.

Copy link

github-actions bot commented Jul 24, 2024

Static Badge

Last ran on July 23, 2024 21:51:23 CDT
Checking merge of (c3ea9b9) into main (edc20d4)

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments I left were informational and don't necessarily require a change here. Approving.

@metal-messiah metal-messiah merged commit 63ab04f into main Jul 26, 2024
16 of 18 checks passed
@metal-messiah metal-messiah deleted the generic-events-feature branch July 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants