-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create generic events feature #1121
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
- Coverage 87.79% 87.26% -0.53%
==========================================
Files 162 165 +3
Lines 7265 7358 +93
Branches 1426 1452 +26
==========================================
+ Hits 6378 6421 +43
- Misses 770 809 +39
- Partials 117 128 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing package.json updates for this feature and for soft nav. Should also update the npm tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the comments I left were informational and don't necessarily require a change here. Approving.
Create a feature that will normalize, aggregate and harvest all generic events.
Related Issue(s)
NR-291171
Testing
Feature testing to be added when real data begins flowing through the new feature