Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize bundle size with warning codes #1111

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

metal-messiah
Copy link
Member

Decrease bundle size by converting static strings to warning codes with an accompanying link to a web resource.

Overview

This was conducted as part of an innovation project.

Related Issue(s)

Testing

Copy link

github-actions bot commented Jul 14, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 34.25 kB / 11.92 kB (gzip) 32.29 kB / 11.3 kB (gzip) -5.72% / -5.17% (gzip)
lite async-chunk 50.09 kB / 16.18 kB (gzip) 49.74 kB / 16.03 kB (gzip) -0.69% / -0.93% (gzip)
pro loader 54.92 kB / 18.57 kB (gzip) 53.15 kB / 18.02 kB (gzip) -3.21% / -2.98% (gzip)
pro async-chunk 96.73 kB / 28.99 kB (gzip) 95.97 kB / 28.7 kB (gzip) -0.78% / -1.01% (gzip)
spa loader 62.86 kB / 21.01 kB (gzip) 61.09 kB / 20.45 kB (gzip) -2.8% / -2.65% (gzip)
spa async-chunk 111.84 kB / 33.37 kB (gzip) 111.02 kB / 33.03 kB (gzip) -0.74% / -1.02% (gzip)
lite-polyfills loader 127.83 kB / 41.24 kB (gzip) 125.84 kB / 40.58 kB (gzip) -1.56% / -1.6% (gzip)
lite-polyfills async-chunk 63.99 kB / 18.45 kB (gzip) 63.67 kB / 18.32 kB (gzip) -0.49% / -0.71% (gzip)
pro-polyfills loader 150.21 kB / 47.54 kB (gzip) 148.4 kB / 46.91 kB (gzip) -1.21% / -1.31% (gzip)
pro-polyfills async-chunk 116.73 kB / 31.22 kB (gzip) 116 kB / 30.94 kB (gzip) -0.63% / -0.91% (gzip)
spa-polyfills loader 158.41 kB / 49.69 kB (gzip) 156.6 kB / 49.08 kB (gzip) -1.15% / -1.24% (gzip)
spa-polyfills async-chunk 133.71 kB / 35.92 kB (gzip) 132.9 kB / 35.6 kB (gzip) -0.6% / -0.89% (gzip)

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.69%. Comparing base (c732d8a) to head (63f6091).
Report is 1 commits behind head on main.

Files Patch % Lines
src/loaders/micro-agent.js 0.00% 4 Missing and 1 partial ⚠️
src/loaders/agent.js 0.00% 2 Missing and 1 partial ⚠️
src/common/config/state/configurable.js 75.00% 1 Missing ⚠️
src/common/context/shared-context.js 50.00% 1 Missing ⚠️
src/common/session/session-entity.js 50.00% 1 Missing ⚠️
src/features/page_view_event/aggregate/index.js 50.00% 1 Missing ⚠️
src/loaders/agent-base.js 0.00% 0 Missing and 1 partial ⚠️
src/loaders/api/api.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   87.77%   87.69%   -0.08%     
==========================================
  Files         162      162              
  Lines        7263     7259       -4     
  Branches     1426     1425       -1     
==========================================
- Hits         6375     6366       -9     
- Misses        772      777       +5     
  Partials      116      116              
Flag Coverage Δ
integration-tests 91.71% <73.91%> (-0.19%) ⬇️
unit-tests 76.43% <57.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah marked this pull request as ready for review July 15, 2024 15:05
Copy link

github-actions bot commented Jul 15, 2024

Static Badge

Last ran on July 15, 2024 13:20:07 CDT
Checking merge of (63f6091) into main (c732d8a)

@metal-messiah metal-messiah merged commit 6ab7d2b into main Jul 16, 2024
32 of 34 checks passed
@metal-messiah metal-messiah deleted the exp-error-codes branch July 16, 2024 16:01
@villelahdenvuo
Copy link

Fixes #787 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants