-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logging bundle optimization #1089
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
+ Coverage 87.62% 87.66% +0.03%
==========================================
Files 162 162
Lines 7249 7254 +5
Branches 1421 1421
==========================================
+ Hits 6352 6359 +7
+ Misses 781 779 -2
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still wonder if we could do something like having two constants files, one with all the codes, and one that maps the codes to strings that gets async loaded in the metrics agg or something. I know we can't do just one constants file because webpack won't split individual js files.
Improve the bundle size of the logging feature by moving non-critical pieces to the aggregation portion of the agent code.
Overview
This PR shifts deferrable portions of the logging feature logic to the aggregator portion of the agent to improve loader build size.
Related Issue(s)
Testing
Tests have been shifted to match new locations, but logic should remain