Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Logging API entry points and central handler #1052

Merged
merged 1 commit into from
May 30, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented May 28, 2024

Add Logging API interface and central handling mechanism as customer interface for capturing logging data

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-251068
https://new-relic.atlassian.net/browse/NR-251074

Testing

Jest unit tests have been updated to check for EE events. WDIO tests to be added after feature/havesting is implemented

@metal-messiah metal-messiah changed the title Add Logging API entry points and central handler feat: Add Logging API entry points and central handler May 28, 2024
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.44 kB / 11.03 kB (gzip) 31.78 kB / 11.13 kB (gzip) 1.1% / 0.92% (gzip)
lite async-chunk 50.97 kB / 16.57 kB (gzip) 50.97 kB / 16.57 kB (gzip) 0% / 0% (gzip)
pro loader 52.7 kB / 17.87 kB (gzip) 53.05 kB / 17.97 kB (gzip) 0.66% / 0.55% (gzip)
pro async-chunk 93.81 kB / 28.31 kB (gzip) 93.81 kB / 28.31 kB (gzip) 0% / 0% (gzip)
spa loader 60.81 kB / 20.37 kB (gzip) 61.16 kB / 20.48 kB (gzip) 0.57% / 0.54% (gzip)
spa async-chunk 109.07 kB / 32.74 kB (gzip) 109.07 kB / 32.74 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 125.44 kB / 40.32 kB (gzip) 125.76 kB / 40.42 kB (gzip) 0.25% / 0.24% (gzip)
lite-polyfills async-chunk 65.71 kB / 18.91 kB (gzip) 65.71 kB / 18.91 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 147.15 kB / 46.58 kB (gzip) 147.47 kB / 46.69 kB (gzip) 0.22% / 0.24% (gzip)
pro-polyfills async-chunk 114.33 kB / 30.27 kB (gzip) 114.33 kB / 30.27 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 155.35 kB / 48.75 kB (gzip) 155.67 kB / 48.83 kB (gzip) 0.2% / 0.17% (gzip)
spa-polyfills async-chunk 131.33 kB / 34.9 kB (gzip) 131.33 kB / 34.9 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (b342053) to head (8370ff6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   87.56%   87.57%   +0.01%     
==========================================
  Files         156      156              
  Lines        7108     7115       +7     
  Branches     1397     1398       +1     
==========================================
+ Hits         6224     6231       +7     
  Misses        769      769              
  Partials      115      115              
Flag Coverage Δ
unit-tests 76.21% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah changed the title feat: Add Logging API entry points and central handler feat: Add Logging API entry points and central handler as customer interface for capturing logging data May 28, 2024
Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments on our favorite word context

@metal-messiah metal-messiah changed the title feat: Add Logging API entry points and central handler as customer interface for capturing logging data feat: Add Logging API entry points and central handler May 30, 2024
@metal-messiah metal-messiah merged commit face445 into main May 30, 2024
20 of 24 checks passed
@metal-messiah metal-messiah deleted the browser-logs-central-method branch May 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants