Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up xhrWrappable #1000

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix: Clean up xhrWrappable #1000

merged 2 commits into from
Apr 24, 2024

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Apr 23, 2024

Remove xhrWrappable which is an old variable checking for addEventListener on XHR. It is expected to have no compatibility impact on modern standard frameworks or browsers.

Overview

Delete presumably dead and ineffectively redundant code blocking trace, ajax, and spa if the addEventListener on XHR prototype somehow isn't a function. We've had no report of such case. This is a remnant of old IE.

Related Issue(s)

Follow-up of https://new-relic.atlassian.net/browse/NR-57395

Testing

Standard

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.83 kB / 11.13 kB (gzip) 31.75 kB / 11.1 kB (gzip) -0.25% / -0.26% (gzip)
lite async-chunk 51 kB / 16.59 kB (gzip) 51 kB / 16.59 kB (gzip) 0% / 0% (gzip)
pro loader 51.75 kB / 17.55 kB (gzip) 51.64 kB / 17.51 kB (gzip) -0.21% / -0.22% (gzip)
pro async-chunk 93.55 kB / 28.58 kB (gzip) 93.51 kB / 28.57 kB (gzip) -0.04% / -0.05% (gzip)
spa loader 59.7 kB / 19.98 kB (gzip) 59.55 kB / 19.93 kB (gzip) -0.25% / -0.26% (gzip)
spa async-chunk 108.62 kB / 32.99 kB (gzip) 108.58 kB / 32.97 kB (gzip) -0.04% / -0.04% (gzip)
lite-polyfills loader 125.76 kB / 40.43 kB (gzip) 125.65 kB / 40.39 kB (gzip) -0.09% / -0.1% (gzip)
lite-polyfills async-chunk 65.72 kB / 18.91 kB (gzip) 65.72 kB / 18.91 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 146.01 kB / 46.43 kB (gzip) 145.73 kB / 46.36 kB (gzip) -0.19% / -0.14% (gzip)
pro-polyfills async-chunk 128.4 kB / 33.43 kB (gzip) 128.36 kB / 33.41 kB (gzip) -0.03% / -0.05% (gzip)
spa-polyfills loader 154.03 kB / 48.55 kB (gzip) 153.71 kB / 48.49 kB (gzip) -0.21% / -0.14% (gzip)
spa-polyfills async-chunk 145.21 kB / 38.05 kB (gzip) 145.17 kB / 38.03 kB (gzip) -0.03% / -0.05% (gzip)

Copy link

github-actions bot commented Apr 23, 2024

Static Badge

Last ran on April 23, 2024 16:22:30 CDT
Checking merge of (b05df46) into main (3cba945)

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (3cba945) to head (b05df46).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
+ Coverage   83.89%   83.93%   +0.03%     
==========================================
  Files         154      154              
  Lines        7165     7157       -8     
  Branches     1420     1417       -3     
==========================================
- Hits         6011     6007       -4     
+ Misses        983      982       -1     
+ Partials      171      168       -3     
Flag Coverage Δ
integration-tests 90.47% <ø> (-0.01%) ⬇️
unit-tests 67.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 merged commit 5e28fb7 into main Apr 24, 2024
51 checks passed
@cwli24 cwli24 deleted the remove-xhr-wrappable branch April 24, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants