-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up xhrWrappable #1000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 83.89% 83.93% +0.03%
==========================================
Files 154 154
Lines 7165 7157 -8
Branches 1420 1417 -3
==========================================
- Hits 6011 6007 -4
+ Misses 983 982 -1
+ Partials 171 168 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
metal-messiah
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
xhrWrappable
which is an old variable checking foraddEventListener
on XHR. It is expected to have no compatibility impact on modern standard frameworks or browsers.Overview
Delete presumably dead and ineffectively redundant code blocking trace, ajax, and spa if the addEventListener on XHR prototype somehow isn't a function. We've had no report of such case. This is a remnant of old IE.
Related Issue(s)
Follow-up of https://new-relic.atlassian.net/browse/NR-57395
Testing
Standard