Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show up to 5 links in the right rail #580

Closed
jerelmiller opened this issue Aug 11, 2020 · 1 comment · Fixed by #597
Closed

Show up to 5 links in the right rail #580

jerelmiller opened this issue Aug 11, 2020 · 1 comment · Fixed by #597
Assignees
@jerelmiller
Labels
enhancement New feature or request released sp:2 Story Point(s): 2
Milestone
MMF 12: Make sear...

Comments

@jerelmiller
Copy link
Contributor

jerelmiller commented Aug 11, 2020 •
edited
Loading

Description

We want to show up to 5 links in the right rail component. These can be a mix of frontmatter-defined links and dynamic content links. Let's prioritize frontmatter-defined links first, then back fill results up to 5 links. For example, if there are 3 frontmatter-defined links, we want 2 search results from Swiftype for a total of 5. If there are 5 links defined in frontmatter, we should skip the request to Swiftype entirely for search results.

NOTE: This should consume the data from the GraphQL schema from #589 .
@jerelmiller jerelmiller added the enhancement New feature or request label Aug 11, 2020
@jerelmiller jerelmiller added the sp:2 Story Point(s): 2 label Aug 11, 2020
@jerelmiller jerelmiller self-assigned this Aug 13, 2020
@jerelmiller jerelmiller mentioned this issue Aug 13, 2020
Merged
@jerelmiller jerelmiller linked a pull request Aug 13, 2020 that will close this issue
Related content in the right rail #597
Merged
@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerelmiller jerelmiller

Labels
enhancement New feature or request released sp:2 Story Point(s): 2
Projects
None yet
Milestone
MMF 12: Make search great again
Development

Successfully merging a pull request may close this issue.

Related content in the right rail newrelic/developer-website
2 participants
@jerelmiller @nr-opensource-bot