Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Navigation onpage load improvement #505

Closed
markweitzel opened this issue Jul 30, 2020 · 4 comments · Fixed by #563
Closed

Side Navigation onpage load improvement #505

markweitzel opened this issue Jul 30, 2020 · 4 comments · Fixed by #563
Assignees
Labels
enhancement New feature or request released

Comments

@markweitzel
Copy link
Contributor

markweitzel commented Jul 30, 2020

Issue

Now that we have more guides (and more top level items, e.g. podcasts), the top level items don't show. Let's think about how we can modify this to show all the top level items when a user first lands on the page.

Design Considerations

One simple thing to do, is on page load, have the menus load as collapsed instead of expanded as they are now. Similar to how Apollo does it: https://www.apollographql.com/docs/

Acceptance Criteria

  • on page load show side navigation as collapsed instead of expanded.
@markweitzel markweitzel added the enhancement New feature or request label Jul 30, 2020
@jpvajda
Copy link
Contributor

jpvajda commented Aug 4, 2020

One simple thing to do, is on page load, have the menus load as collapsed instead of expanded as they are now. Similar to how Apollo does it: https://www.apollographql.com/docs/

@jpvajda jpvajda changed the title Tighten up left nave to show all top level items... Side Navigation onpage load improvement Aug 4, 2020
@jpvajda
Copy link
Contributor

jpvajda commented Aug 4, 2020

@djsauble thoughts?

@djsauble
Copy link
Contributor

djsauble commented Aug 7, 2020

I agree with all of the above. We have enough top-level nav items that loading them collapsed by default shouldn't look weird.

@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.10.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants