Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sidenav does not stay expanded on page refresh #340

Closed
jerelmiller opened this issue Jun 29, 2020 · 2 comments
Closed

The sidenav does not stay expanded on page refresh #340

jerelmiller opened this issue Jun 29, 2020 · 2 comments
Labels
bug Something isn't working P3 Priority 3

Comments

@jerelmiller
Copy link
Contributor

Description

When navigating the site, the sidenav expands/collapses the sections as you expect when visiting pages within a section. However, if you visit a page, then refresh, you'll notice the sidebar expands every section and does not highlight the current page you are on.

Steps to reproduce

  1. Navigate to any page except the home page
  2. Notice the side nav is collapsed/expanded propertly
  3. Refresh the page
  4. Notice that all sections have been expanded again and the current page is not properly bolded.

Expected behavior

Refreshing the page should not matter whether the sidenav is expanded or collapsed.

Screenshots

When navigating:
Screen Shot 2020-06-29 at 3 15 50 PM

After refreshing:
Screen Shot 2020-06-29 at 3 15 57 PM

@jerelmiller jerelmiller added the bug Something isn't working label Jun 29, 2020
@jerelmiller
Copy link
Contributor Author

It looks like this might be a problem with the "server" generated markup. If I inspect the raw HTML downloaded for these pages, the HTML does not reflect the proper expanded/collapsed state.

@jpvajda jpvajda added the P2 Priority 2 label Jun 30, 2020
@jerelmiller jerelmiller mentioned this issue Jul 1, 2020
@LizBaker
Copy link
Contributor

This has been mostly resolved. Though I have noticed that upon refresh you see the expanded nav blink before showing the correct collapsed/expanded state

@jpvajda jpvajda added P3 Priority 3 and removed P2 Priority 2 labels Sep 23, 2020
@jpvajda jpvajda closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Priority 3
Projects
None yet
Development

No branches or pull requests

3 participants