Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Public Catalog] Quickstart Details Stijn nits #1684

Closed
4 of 5 tasks
jpvajda opened this issue Sep 21, 2021 · 1 comment · Fixed by #1685
Closed
4 of 5 tasks

[Public Catalog] Quickstart Details Stijn nits #1684

jpvajda opened this issue Sep 21, 2021 · 1 comment · Fixed by #1685
Assignees
Labels
bug Something isn't working P2 Priority 2 readiness sp:5 Story Point(s): 5

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Sep 21, 2021

Acceptance Criteria

  • make the docs overview tile clickable and link the the docs url --> won't do
  • align label position on datasource tab below doc description

screenshots

Screen Shot 2021-09-21 at 5 50 16 PM

Screen Shot 2021-09-21 at 5 50 21 PM

  • what's included on public site uses h3, but in-product uses an h2 for headers
  • in-product we have an h2 title About this quickstart, which we don’t have public. I think we should remove the About this quickstart in-product because we end up with too many headers
  • (I also notice that the font size for text public is 16px, in-product is 12px (maybe that’s a platform thing and harder to control, we can start with aligning the headers))\

confirmed the platform has a specific font size set we can't override.
all other issues are resolved in catalog-pack-details 48

@jpvajda jpvajda self-assigned this Sep 21, 2021
@jpvajda jpvajda added bug Something isn't working P2 Priority 2 readiness sp:2 Story Point(s): 2 labels Sep 21, 2021
@jpvajda
Copy link
Contributor Author

jpvajda commented Sep 21, 2021

I'm going to ask @danielgolden about making just one tile clickable on over view as it feels a bit odd to me from a UX perspective.

@jpvajda jpvajda linked a pull request Sep 22, 2021 that will close this issue
@jpvajda jpvajda added sp:5 Story Point(s): 5 and removed sp:2 Story Point(s): 2 labels Sep 23, 2021
@jpvajda jpvajda closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Priority 2 readiness sp:5 Story Point(s): 5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant