Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code snippets: Disable line numbers by default #165

Closed
theletterf opened this issue Jun 17, 2020 · 2 comments · Fixed by #409
Closed

Code snippets: Disable line numbers by default #165

theletterf opened this issue Jun 17, 2020 · 2 comments · Fixed by #409
Labels
enhancement New feature or request released

Comments

@theletterf
Copy link
Contributor

Description

I often find myself adding lineNumbers=false to code snippets manually. I think they add little value, and we don't really reference line numbers.
@theletterf theletterf added the bug Something isn't working label Jun 17, 2020
@jpvajda
Copy link
Contributor

jpvajda commented Jun 27, 2020 •
edited
Loading

@theletterf we can consider making this default in the component thanks for reporting this.

@jpvajda jpvajda added enhancement New feature or request documentation Improvements or additions to documentation and removed bug Something isn't working enhancement New feature or request documentation Improvements or additions to documentation labels Jun 27, 2020
@jerelmiller jerelmiller mentioned this issue Jul 8, 2020
Merged
@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify code blocks into a single component newrelic/developer-website
3 participants
@jpvajda @theletterf @nr-opensource-bot