From 05f74d529918aca93895b1686b05e2b532011ffd Mon Sep 17 00:00:00 2001 From: Kris Kenney <70179215+nr-kkenney@users.noreply.github.com> Date: Fri, 9 Jul 2021 16:40:43 -0700 Subject: [PATCH 1/4] feat: add final copy for dashboards, alerts, synthetics * added final copy for tabs except for visualization which is still using placeholder text. --- src/templates/ObservabilityPackDetails.js | 92 +++++++++-------------- 1 file changed, 35 insertions(+), 57 deletions(-) diff --git a/src/templates/ObservabilityPackDetails.js b/src/templates/ObservabilityPackDetails.js index 66d74723a..f9511176c 100644 --- a/src/templates/ObservabilityPackDetails.js +++ b/src/templates/ObservabilityPackDetails.js @@ -130,31 +130,11 @@ const ObservabilityPackDetails = ({ data, location }) => { margin-bottom: 16px; `} > - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. + Before you install the {pack.name} observability pack, make + sure you meet the requirements documented below. - - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. - {pack.dashboards?.map((dashboard) => ( <>

{dashboard.name}

@@ -167,6 +147,16 @@ const ObservabilityPackDetails = ({ data, location }) => { )} ))} + + {pack.name} observability pack contains{' '} + {pack.dashboards?.length ?? 0} dashboards. These interactive + visualizations let you easily explore your data, understand + context, and resolve problems faster. + { margin-bottom: 16px; `} > - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. + {pack.name} observability pack contains{' '} + {pack.alerts?.length ?? 0} alerts, which detect changes in key + performance metrics. Integrate these alerts with your favorite + tools (like Slack, PagerDuty, etc.) and New Relic will let you + know when something needs your attention. - {pack.alerts?.map((alert) => ( - <> -

{alert.name}

- {alert.description && ( - <> -

Description

-

{alert.description}

- - )} - - ))} { margin-bottom: 16px; `} > - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. + {pack.name} observability pack includes{' '} + {pack.synthetics?.length ?? 0} Synthetics checks. These checks + will run automatically to simulate user traffic and ensure + your site or API endpoint is not only available, but fully + functional. @@ -233,14 +206,10 @@ const ObservabilityPackDetails = ({ data, location }) => { margin-bottom: 16px; `} > - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. + Nerdpacks are custom applications that extend the monitoring + capabilities of the New Relic One platform. {pack.name} + observability pack includes {pack.nerdpacks?.length ?? 0} + Nerdpacks to make sure you’re monitoring what matters. @@ -331,6 +300,15 @@ export const pageQuery = graphql` screenshots url } + alerts { + name + } + synthetics { + name + } + nerdpacks { + name + } authors } } From 2f55d018b8c2aebd74667846f1c31f7c1a60e663 Mon Sep 17 00:00:00 2001 From: Kris Kenney <70179215+nr-kkenney@users.noreply.github.com> Date: Mon, 12 Jul 2021 14:23:40 -0700 Subject: [PATCH 2/4] chore: import pluralize, use it for final copy --- package.json | 1 + src/templates/ObservabilityPackDetails.js | 33 ++++++++++++++--------- yarn.lock | 5 ++++ 3 files changed, 26 insertions(+), 13 deletions(-) diff --git a/package.json b/package.json index 420db0838..282e7fedb 100644 --- a/package.json +++ b/package.json @@ -37,6 +37,7 @@ "lodash.get": "^4.4.2", "node-fetch": "^2.6.1", "node-sass": "^4.14.1", + "pluralize": "^8.0.0", "prism-react-renderer": "^1.1.1", "prismjs": "^1.21.0", "prop-types": "^15.7.2", diff --git a/src/templates/ObservabilityPackDetails.js b/src/templates/ObservabilityPackDetails.js index f9511176c..0af01f0a7 100644 --- a/src/templates/ObservabilityPackDetails.js +++ b/src/templates/ObservabilityPackDetails.js @@ -20,6 +20,7 @@ import InstallButton from '../components/InstallButton'; import ImageSlider from '../components/ImageSlider'; import getPackUrl from '../utils/get-pack-url'; import Markdown from '../components/Markdown'; +import pluralize from 'pluralize'; const allowedElements = [ 'h1', @@ -153,9 +154,9 @@ const ObservabilityPackDetails = ({ data, location }) => { `} > {pack.name} observability pack contains{' '} - {pack.dashboards?.length ?? 0} dashboards. These interactive - visualizations let you easily explore your data, understand - context, and resolve problems faster. + {pluralize('dashboard', pack.dashboards?.length ?? 0, true)}. + These interactive visualizations let you easily explore your + data, understand context, and resolve problems faster. @@ -165,10 +166,11 @@ const ObservabilityPackDetails = ({ data, location }) => { `} > {pack.name} observability pack contains{' '} - {pack.alerts?.length ?? 0} alerts, which detect changes in key - performance metrics. Integrate these alerts with your favorite - tools (like Slack, PagerDuty, etc.) and New Relic will let you - know when something needs your attention. + {pluralize('alert', pack.alerts?.length ?? 0, true)}, which + detect changes in key performance metrics. Integrate these + alerts with your favorite tools (like Slack, PagerDuty, etc.) + and New Relic will let you know when something needs your + attention. @@ -178,10 +180,14 @@ const ObservabilityPackDetails = ({ data, location }) => { `} > {pack.name} observability pack includes{' '} - {pack.synthetics?.length ?? 0} Synthetics checks. These checks - will run automatically to simulate user traffic and ensure - your site or API endpoint is not only available, but fully - functional. + {pluralize( + 'Synthetics check', + pack.synthetics?.length ?? 0, + true + )} + . These checks will run automatically to simulate user traffic + and ensure your site or API endpoint is not only available, + but fully functional. @@ -208,8 +214,9 @@ const ObservabilityPackDetails = ({ data, location }) => { > Nerdpacks are custom applications that extend the monitoring capabilities of the New Relic One platform. {pack.name} - observability pack includes {pack.nerdpacks?.length ?? 0} - Nerdpacks to make sure you’re monitoring what matters. + observability pack includes{' '} + {pluralize('Nerdpack', pack.nerdpacks?.length ?? 0, true)} to + make sure you’re monitoring what matters. diff --git a/yarn.lock b/yarn.lock index 0631c706c..bcce591f5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -15120,6 +15120,11 @@ pluralize@^7.0.0: resolved "https://registry.npmjs.org/pluralize/-/pluralize-7.0.0.tgz" integrity sha512-ARhBOdzS3e41FbkW/XWrTEtukqqLoK5+Z/4UeDaLuSW+39JPeFgs4gCGqsrJHVZX0fUrx//4OF0K1CUGwlIFow== +pluralize@^8.0.0: + version "8.0.0" + resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-8.0.0.tgz#1a6fa16a38d12a1901e0320fa017051c539ce3b1" + integrity sha512-Nc3IT5yHzflTfbjgqWcCPpo7DaKy4FnpB0l/zCAW0Tc7jxAiuqSxHasntB3D7887LSrA93kDJ9IXovxJYxyLCA== + pngjs@^3.0.0, pngjs@^3.3.3: version "3.4.0" resolved "https://registry.npmjs.org/pngjs/-/pngjs-3.4.0.tgz" From 68b8fa5454713c82e6188718cff2bd07a778477d Mon Sep 17 00:00:00 2001 From: Kris Kenney <70179215+nr-kkenney@users.noreply.github.com> Date: Mon, 12 Jul 2021 15:08:18 -0700 Subject: [PATCH 3/4] chore: edit copy, remove fields from query * edited copy to match pluralness * removed currently non-existent fields from query --- src/templates/ObservabilityPackDetails.js | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/templates/ObservabilityPackDetails.js b/src/templates/ObservabilityPackDetails.js index 0af01f0a7..87879b068 100644 --- a/src/templates/ObservabilityPackDetails.js +++ b/src/templates/ObservabilityPackDetails.js @@ -166,11 +166,11 @@ const ObservabilityPackDetails = ({ data, location }) => { `} > {pack.name} observability pack contains{' '} - {pluralize('alert', pack.alerts?.length ?? 0, true)}, which - detect changes in key performance metrics. Integrate these - alerts with your favorite tools (like Slack, PagerDuty, etc.) - and New Relic will let you know when something needs your - attention. + {pluralize('alert', pack.alerts?.length ?? 0, true)}. These + alerts detect changes in key performance metrics. Integrate + these alerts with your favorite tools (like Slack, PagerDuty, + etc.) and New Relic will let you know when something needs + your attention. @@ -307,15 +307,6 @@ export const pageQuery = graphql` screenshots url } - alerts { - name - } - synthetics { - name - } - nerdpacks { - name - } authors } } From 6ca53f03ba7086f0ece198018baed59b8ee22f98 Mon Sep 17 00:00:00 2001 From: Kris Kenney <70179215+nr-kkenney@users.noreply.github.com> Date: Wed, 14 Jul 2021 09:17:17 -0700 Subject: [PATCH 4/4] chore: add final copy for visualizations --- src/templates/ObservabilityPackDetails.js | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/templates/ObservabilityPackDetails.js b/src/templates/ObservabilityPackDetails.js index 87879b068..e24a5f94e 100644 --- a/src/templates/ObservabilityPackDetails.js +++ b/src/templates/ObservabilityPackDetails.js @@ -196,14 +196,15 @@ const ObservabilityPackDetails = ({ data, location }) => { margin-bottom: 16px; `} > - Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed - do eiusmod tempor incididunt ut labore et dolore magna aliqua. - Ut enim ad minim veniam, quis nostrud exercitation ullamco - laboris nisi ut aliquip ex ea commodo consequat. Duis aute - irure dolor in reprehenderit in voluptate velit esse cillum - dolore eu fugiat nulla pariatur. Excepteur sint occaecat - cupidatat non proident, sunt in culpa qui officia deserunt - mollit anim id est laborum. + {pack.name} observability pack includes{' '} + {pluralize( + 'visualization', + pack.visualizations?.length ?? 0, + true + )} + . These charts have been customized to represent data in a way + that a standard dashboard isn’t able to, so you can monitor + what’s essential.