Skip to content

Commit ddd6107

Browse files
committed
refactor: extract condition for determining when to render nav item
1 parent 6e473ea commit ddd6107

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

src/components/NavigationItems.js

+12-13
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,18 @@ const NavigationItems = ({
6363
{showGroup && (
6464
<li className={cx(styles.navLink, styles.groupName)}>{group}</li>
6565
)}
66-
{pages.map((page, index) => (
67-
<NavItem
68-
page={page}
69-
depthLevel={depthLevel}
70-
searchTerm={searchTerm}
71-
filteredPageNames={filteredPageNames}
72-
key={index}
73-
/>
74-
))}
66+
{pages.map((page, index) =>
67+
filteredPageNames?.includes(page.displayName) ||
68+
!filteredPageNames ? (
69+
<NavItem
70+
page={page}
71+
depthLevel={depthLevel}
72+
searchTerm={searchTerm}
73+
filteredPageNames={filteredPageNames}
74+
key={index}
75+
/>
76+
) : null
77+
)}
7578
</Fragment>
7679
);
7780
});
@@ -121,10 +124,6 @@ const NavItem = ({ page, depthLevel, searchTerm, filteredPageNames }) => {
121124
? getHighlightedText(page.displayName, searchTerm)
122125
: page.displayName;
123126

124-
if (filteredPageNames && !filteredPageNames.includes(page.displayName)) {
125-
return null;
126-
}
127-
128127
return (
129128
<>
130129
<div

0 commit comments

Comments
 (0)