Fix for Polymer#27

nevir · May 7, 2014 · 98e9c9b · 98e9c9b
1 parent 437dfd1
commit 98e9c9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/instance/properties.js b/src/instance/properties.js
@@ -133,10 +133,8 @@
     },
     closeNamedObservers: function() {
       if (this._namedObservers) {
-        var keys=Object.keys(this._namedObservers);
-        for (var i=0, l=keys.length, k, o; (i < l) && (k=keys[i]); i++) {
-          o = this._namedObservers[k];
-          o.close();
+        for (var i in this._namedObservers) {
+          this.closeNamedObserver(i);
         }
         this._namedObservers = {};
       }

diff --git a/test/html/property-array-changes.html b/test/html/property-array-changes.html
@@ -67,9 +67,7 @@
             test5: function() {
               chai.assert.equal(this.a.length, 1, 'noticed array removal');
               a.push(55);
-              setTimeout(function() {
-                this.nextTest();
-              }.bind(this), 50);
+              setTimeout(this.nextTest.bind(this), 0);
             },
             test6: function() {
               chai.assert.equal(this.a.length, 1, 'old array properly unobserved');
@@ -78,6 +76,17 @@
             },
             test7: function() {
               chai.assert.equal(this.b.length, 1, 'noticed array addition');
+              this.async(this.nextTest);
+            },
+            test8: function() {
+              this.a = '';
+            },
+            test9: function() {
+              this.parentNode.removeChild(this);
+              setTimeout(this.nextTest.bind(this), 50);
+            },
+            test10: function() {
+              chai.assert.isTrue(this._unbound, 'element unbound without error');
             }
           });
         })();