-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating CanProCo M0 data with Erin's new data #296
Comments
This is a big change! Congratulations on getting it done (and all the investigations before). Git-annex seems fine (including for all the intermediate commits on the branch). Bids-validator complains about MISSING_SESSION for lots of subjects, but I guess that's expected; not everyone has both M0 and M12. (I'm a bit surprised to see some subjects with M12 but no M0, though, is that normal?) I can add a Bids-validator also complains about INCONSISTENT_SUBJECTS (that is, missing T2w images) for
Can you add |
Thanks for checking everything @mguaypaq . We didn't have any instructions whether a subject should always be included at M0. Therefore, having subjects at M12 but not M0 isn't a problem.
However, before merging, I realized that there was still an issue with the splitting of MT files for M12 subjects. Working on this now, using the code |
MT files were split using the code from All good on my side ! Thanks for your review 😀 |
Merged into master, with an extra commit to ignore MISSING_SESSION in bids-validator. |
I am creating this issue to detail the work which has been done on the CanProCo data on branch :
plb/add_erin_corrected_data_at_M0
. This comes from the fact that some M12 images were confused with M0 images when sent to us. We realized that when we saw that some M0 and M12 images were identical :More details can be found in this issue 39 !
Tagging @mguaypaq for verification and merging.
The text was updated successfully, but these errors were encountered: