New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No test for loading the serialized model? #460

Open

philip30 opened this issue Jul 9, 2018 · 1 comment

Labels

Contributor

philip30 commented Jul 9, 2018

Is there currently a guarantee that the serialized parameters will be the same as when we save the model?

I think we should make a test like:

x = initialize model
do training for several steps
path = save the model(x)
y = load the model(path)
assertEqual(x.param == y.param) ?

Contributor

msperber commented Jul 9, 2018

I think we're currently only testing that loading a model doesn't cause a crash, so adding a correctness test seems like a nice idea.

neubig added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment