Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all cmd-*-vpp repos that use edwarnicke/vpphelper #4

Closed
denis-tingaikin opened this issue Jul 24, 2023 · 2 comments
Closed

Update all cmd-*-vpp repos that use edwarnicke/vpphelper #4

denis-tingaikin opened this issue Jul 24, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jul 24, 2023

Update all cmd-*-vpp repos that use edwarnicke/vpphelper. For example (cmd-nsc-vpp):

  • Replace github.com/edwarnicke/vpphelper v0.2.0 with github.com/networkservicemesh/vpphelper main
  • Update imports in *.go files (edwarnicke --> networkservicemesh)
  • go mod tidy

To test it:

  • docker build -t {cmd-nsc-vpp} .
  • use this image in your cluster
@denis-tingaikin denis-tingaikin added the enhancement New feature or request label Jul 24, 2023
@bellycat77
Copy link

Also, need to do before commit:

go fmt
goimports -w -local github.com/networkservicemesh .
go generate ./...

@denis-tingaikin
Copy link
Member Author

Seems like done.

Other issues we'll consider in separate tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants