Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint job failure #1255

Closed
glazychev-art opened this issue Apr 5, 2022 · 0 comments
Closed

golangci-lint job failure #1255

glazychev-art opened this issue Apr 5, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@glazychev-art
Copy link
Contributor

Expected Behavior

Current Behavior

golangci-lint job fails on may repositories now.

To solve this, we need to check ci workflow of all NSM repositories and add:

  golangci-lint:
...
      - name: Setup Go
        uses: actions/setup-go@v1
        with:
          go-version: 1.16
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v3
...

Failure Information (for bugs)

Example: https://github.com/networkservicemesh/sdk-vpp/runs/5817274207?check_suite_focus=true

Steps to Reproduce

  1. Open PR in sdk
  2. We can see that golangci-lint job is red
  3. ...
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Apr 5, 2022
This was referenced Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants